i#1547 Added syscalls which are used SYSTEM_INFORMATION_CLASS

i#1547 Added syscalls which are used SYSTEM_INFORMATION_CLASS

Added 4 syscalls which are used undocumented SYSTEM_INFORMATION_CLASS
enumeration.

NtQuerySystemInformation
NtSetSystemInformation
NtQuerySystemInformationWow64
NtQuerySystemInformationEx

BUG=1547
R=bruening@google.com

[Maxim Shudrak, 2014-10-31 17:13:06]

Added syscalls which are used undocumented SYSTEM_INFORMATION_CLASS enumeration.
PTAL.

P.S. What about https://codereview.appspot.com/159000043/ is it possible to use
WRK?

[Maxim Shudrak, 2014-10-31 19:41:50]

fixed mistake

[zhaoqin, 2014-11-10 04:15:23]

the biggest complain is the sysnum_QuerySystemInformationWow64 and
syscall_Wow64GetNativeSystemInformation name mismatch.
Should we have consistent name for it?

https://codereview.appspot.com/168860045/diff/20001/drsyscall/table_windows_n...
File drsyscall/table_windows_ntoskrnl_infoclass.c (right):

https://codereview.appspot.com/168860045/diff/20001/drsyscall/table_windows_n...
drsyscall/table_windows_ntoskrnl_infoclass.c:37: extern drsys_sysnum_t
sysnum_QuerySystemInformationWow64;
The other three the sysnum and syscall matched:
sysnum_QuerySystemInformation vs syscall_QuerySystemInformation_info
Why do we use sysnum_QuerySystemInformationWow64 here but
syscall_Wow64GetNativeSystemInformation_info later, should they have consisten
name and refer to the same syscall?

https://codereview.appspot.com/168860045/diff/20001/drsyscall/table_windows_n...
drsyscall/table_windows_ntoskrnl_infoclass.c:743:
{{0,0},"NtQuerySystemInformation.SystemBasicInformation",
OK|SYSINFO_RET_SMALL_WRITE_LAST, RNTST, 4,
I can see using macro to short this line for "OK|SYSINFO_RET_SMALL_WRITE_LAST,
RNTST, 4,", seems repeated many times.
But since others did not do it, I am fine with it now.

https://codereview.appspot.com/168860045/diff/20001/drsyscall/table_windows_n...
drsyscall/table_windows_ntoskrnl_infoclass.c:744:
ENTRY_QuerySystemInformation("SystemBasicInformation",
"_SYSTEM_BASIC_INFORMATION")
I guess we can auto-extend the _INFOMRATION in the ENTRY_QuerySystemInformation
to short the line.
But since it is not done for other entries, I am fine with it now.

[Maxim Shudrak, 2014-11-22 14:36:32]

https://codereview.appspot.com/168860045/diff/20001/drsyscall/table_windows_n...
File drsyscall/table_windows_ntoskrnl_infoclass.c (right):

https://codereview.appspot.com/168860045/diff/20001/drsyscall/table_windows_n...
drsyscall/table_windows_ntoskrnl_infoclass.c:37: extern drsys_sysnum_t
sysnum_QuerySystemInformationWow64;
On 2014/11/10 04:15:23, zhaoqin wrote:
> The other three the sysnum and syscall matched:
> sysnum_QuerySystemInformation vs syscall_QuerySystemInformation_info
> Why do we use sysnum_QuerySystemInformationWow64 here but
> syscall_Wow64GetNativeSystemInformation_info later, should they have consisten
> name and refer to the same syscall?

I think you're right, I changed sysnum name.

https://codereview.appspot.com/168860045/diff/20001/drsyscall/table_windows_n...
drsyscall/table_windows_ntoskrnl_infoclass.c:743:
{{0,0},"NtQuerySystemInformation.SystemBasicInformation",
OK|SYSINFO_RET_SMALL_WRITE_LAST, RNTST, 4,
On 2014/11/10 04:15:23, zhaoqin wrote:
> I can see using macro to short this line for "OK|SYSINFO_RET_SMALL_WRITE_LAST,
> RNTST, 4,", seems repeated many times.
> But since others did not do it, I am fine with it now.

Ok, I will add this in a separate commit.

https://codereview.appspot.com/168860045/diff/20001/drsyscall/table_windows_n...
drsyscall/table_windows_ntoskrnl_infoclass.c:744:
ENTRY_QuerySystemInformation("SystemBasicInformation",
"_SYSTEM_BASIC_INFORMATION")
On 2014/11/10 04:15:23, zhaoqin wrote:
> I guess we can auto-extend the _INFOMRATION in the
ENTRY_QuerySystemInformation
> to short the line.
> But since it is not done for other entries, I am fine with it now.

Ok, I will add this in a separate commit.

[bruening, 2014-11-22 15:14:52]

https://codereview.appspot.com/168860045/diff/20001/drsyscall/table_windows_n...
File drsyscall/table_windows_ntoskrnl_infoclass.c (right):

https://codereview.appspot.com/168860045/diff/20001/drsyscall/table_windows_n...
drsyscall/table_windows_ntoskrnl_infoclass.c:743:
{{0,0},"NtQuerySystemInformation.SystemBasicInformation",
OK|SYSINFO_RET_SMALL_WRITE_LAST, RNTST, 4,
On 2014/11/22 14:36:31, Maxim Shudrak wrote:
> On 2014/11/10 04:15:23, zhaoqin wrote:
> > I can see using macro to short this line for
"OK|SYSINFO_RET_SMALL_WRITE_LAST,
> > RNTST, 4,", seems repeated many times.
> > But since others did not do it, I am fine with it now.
> 
> Ok, I will add this in a separate commit.

The original tables had a lot of really short abbreviations that IMHO made them
hard to understand, so I have been using fewer shorthand macros.

[zhaoqin, 2014-11-25 16:21:05]

LGTM with nit

https://codereview.appspot.com/168860045/diff/40001/drsyscall/drsyscall_windo...
File drsyscall/drsyscall_windows.c (right):

https://codereview.appspot.com/168860045/diff/40001/drsyscall/drsyscall_windo...
drsyscall/drsyscall_windows.c:2806: drsys_sysnums_equal(&ii->arg->sysnum,
&sysnum_Wow64GetNativeSystemInformation) ||
line too long

https://codereview.appspot.com/168860045/diff/40001/drsyscall/drsyscall_windo...
drsyscall/drsyscall_windows.c:2893: drsys_sysnums_equal(&ii->arg->sysnum,
&sysnum_Wow64GetNativeSystemInformation) ||
line too long

https://codereview.appspot.com/168860045/diff/40001/drsyscall/table_windows_n...
File drsyscall/table_windows_ntoskrnl_infoclass.c (right):

https://codereview.appspot.com/168860045/diff/40001/drsyscall/table_windows_n...
drsyscall/table_windows_ntoskrnl_infoclass.c:743:
{{0,0},"NtQuerySystemInformation.SystemBasicInformation",
OK|SYSINFO_RET_SMALL_WRITE_LAST, RNTST, 4,
hmm, I guess I missed the missing .System*Information here.
So did you test before requesting review?