Issue 159000043: Added secondary tables for 5 Query syscalls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 159000043: Added secondary tables for 5 Query syscalls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by Maxim Shudrak

Modified:
9 years, 6 months ago

Reviewers:
bruening

CC:
drmemory-devs_googlegroups.com

Base URL:
https://drmemory.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

added secondary tables for 5 Query syscalls Added description for new 5 Query syscalls. NtQueryInformationAtom NtQueryInformationFile NtQueryInformationPort NtQueryIoCompletion NtQueryMutant R=bruening@google.com BUG=1547 Committed: https://code.google.com/p/drmemory/source/detail?r=2107

Patch Set 1 #

Patch Set 2 : fixed several copy-paste mistakes #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4289 lines, -4036 lines)			Patch
M	drsyscall/table_windows_ntoskrnl.c	View		1 chunk	+3555 lines, -3575 lines	0 comments	Download
M	drsyscall/table_windows_ntoskrnl_infoclass.c	View	1	1 chunk	+705 lines, -434 lines	1 comment	Download
M	wininc/ndk_lpctypes.h	View		1 chunk	+29 lines, -27 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bruening

LGTM w/ comment https://codereview.appspot.com/159000043/diff/60001/drsyscall/table_windows_ntoskrnl_infoclass.c File drsyscall/table_windows_ntoskrnl_infoclass.c (right): https://codereview.appspot.com/159000043/diff/60001/drsyscall/table_windows_ntoskrnl_infoclass.c#newcode652 drsyscall/table_windows_ntoskrnl_infoclass.c:652: /* source: WRK */ It may ...

9 years, 6 months ago (2014-11-03 21:23:20 UTC) #3

Maxim Shudrak

9 years, 6 months ago (2014-11-05 20:17:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 2107 (presubmit successful).

Expand All Messages | Collapse All Messages