Revised autobeam settings patch

Revised autobeam settings patch
Eliminate context properties measureGrouping, beatLength, and
beamSettings

Create new context properties baseMoment, beatStructure, and
beamExceptions.

Save time-signature-specific settings in context property
timeSignatureSettings

Do away with virtually all special rules for beaming; the beat structure
now governs almost all autobeaming.

Fix documentation

[Carl, 2010-07-05 05:23:40]

I've posted a new patch for review that has the new autobeaming code.

We now have three properties to control autobeaming:  baseMoment (which sets the
smallest time interval used for defining beaming), beatStructure (which defines
the grouping of baseMoment intervals to form beats), and beamExceptions (which
defines cases where the beaming rules are not governed by the beat structure,
such as in 4/4 where beats 1 and 2 are combined if the notes are all 1/8 notes,
but not if they're triplets or 1/16 notes.

Default values of baseMoment and beatStructure are calculated from the time
signature.  However, users are free to define custom values of baseMoment and
beatStructure for time signatures, and the resulting definitions will be stored
in timeSignatureSettings for use whenever the time signature is changed.

All of the regressions are successfully passed.

Please review and give me any comments.

THanks,

Carl


Moving to this new structure has greatly simplified

[t.daniels_treda.co.uk, 2010-07-05 08:07:41]

Hi Carl

Download and applied to current git, but make fails:

make[1]: *** No rule to make target `include/beam-settings.hh', 
needed by `out/beaming-pattern.o'.  Stop.
make[1]: Leaving directory `/media/lilypond-git/lily'
make: *** [all] Error 2

Does this need to be applied over your previous patch or
onto current git?

Trevor


----- Original Message ----- 
From: <Carl.D.Sorensen@gmail.com>
To: <Carl.D.Sorensen@gmail.com>
Cc: <reply@codereview.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Monday, July 05, 2010 6:23 AM
Subject: Revised autobeam settings patch (issue1682049)


> Reviewers: ,
>
> Message:
> I've posted a new patch for review that has the new autobeaming 
> code.
>
> We now have three properties to control autobeaming:  baseMoment 
> (which
> sets the smallest time interval used for defining beaming),
> beatStructure (which defines the grouping of baseMoment intervals 
> to
> form beats), and beamExceptions (which defines cases where the 
> beaming
> rules are not governed by the beat structure, such as in 4/4 where 
> beats
> 1 and 2 are combined if the notes are all 1/8 notes, but not if 
> they're
> triplets or 1/16 notes.
>
> Default values of baseMoment and beatStructure are calculated from 
> the
> time signature.  However, users are free to define custom values 
> of
> baseMoment and beatStructure for time signatures, and the 
> resulting
> definitions will be stored in timeSignatureSettings for use 
> whenever the
> time signature is changed.
>
> All of the regressions are successfully passed.
>
> Please review and give me any comments.
>
> THanks,
>
> Carl
>
>
> Moving to this new structure has greatly simplified
>
> Description:
> Revised autobeam settings patch
> Eliminate context properties measureGrouping, beatLength, and
> beamSettings
>
> Create new context properties baseMoment, beatStructure, and
> beamExceptions.
>
> Save time-signature-specific settings in context property
> timeSignatureSettings
>
> Do away with virtually all special rules for beaming; the beat 
> structure
> now governs almost all autobeaming.
>
> Fix documentation
>
> Please review this at http://codereview.appspot.com/1682049/show
>
> Affected files:
>   M Documentation/de/notation/rhythms.itely
>   M Documentation/es/notation/rhythms.itely
>   M Documentation/fr/notation/rhythms.itely
>   M Documentation/notation/rhythms.itely
>   M Documentation/snippets/new/beam-endings-in-score-context.ly
>   M Documentation/snippets/new/beam-grouping-in-7-8-time.ly
>   M Documentation/snippets/new/compound-time-signatures.ly
>   M 
> Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly
>   M Documentation/snippets/new/fretted-headword.ly
>   M Documentation/snippets/new/reverting-default-beam-endings.ly
>   M input/regression/auto-beam-beaming-override.ly
>   M input/regression/beaming-ternary-metrum.ly
>   M input/regression/les-nereides.ly
>   M lily/auto-beam-engraver.cc
>   M lily/beam-engraver.cc
>   M lily/beam-setting-scheme.cc
>   M lily/beaming-pattern.cc
>   M lily/include/beam-settings.hh
>   M lily/include/beaming-pattern.hh
>   M lily/measure-grouping-engraver.cc
>   M lily/timing-translator.cc
>   M ly/bagpipe.ly
>   M ly/engraver-init.ly
>   M ly/music-functions-init.ly
>   M python/convertrules.py
>   M scm/auto-beam.scm
>   M scm/beam-settings.scm
>   M scm/define-context-properties.scm
>   M scm/define-music-display-methods.scm
>   M scm/lily-library.scm
>   M scm/lily.scm
>   M scm/music-functions.scm
>   A scm/time-signature-settings.scm
>   M scripts/musicxml2ly.py
>
>
>
> _______________________________________________
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/lilypond-devel
>
> 

[Carl, 2010-07-05 11:39:23]

Apply on top of current git.  But remember to do 

make bin-clean

or 

rm lily/out/*

before doing make.  I've removed some c++ files, and so the old binaries have to
go.

Also, I've left some debug statements commented out in scm/auto-beam.scm. 
They'll be removed before pushing, but I got tired of retyping them again and
again....

THanks

[t.daniels_treda.co.uk, 2010-07-05 20:56:36]

Carl, you wrote Monday, July 05, 2010 12:39 PM


> Apply on top of current git.  But remember to do
>
> make bin-clean
>
> or
>
> rm lily/out/*
>
> before doing make.  I've removed some c++ files, and so the old 
> binaries
> have to go.

Of course!  I should have remembered from the last time.
Thanks for your patience!

OK, your patch downloads, applies and compiles fine.
I've run all the beaming tests I have through it and
all looks good!  Definitely the best to date!

One comment, though.

I was puzzled by the beamExceptions for 4/4 time.  These
seem to apply just to quavers, but normally beam exceptions
apply to all shorter notes too, don't they?  I've not (yet)
looked at the code - do you treat 4/4 time specially in
this respect?  Ah, wait a minute.  There's a rule here for
triplet quavers - that will be the one that applies to all
shorter notes.  Clever!

The documentation looks good at first reading, and the
user interface is infinitely better.  I'll go through it
more carefully tomorrow and add comments directly to the
patch, if I have any.

Great work!

Trevor

[Carl, 2010-07-06 02:55:22]

OK, I've loaded patch set 2.  This patch set makes a clean doc build.

To make this patch work, you'll need to do the following:

1) Apply the patch

2) Clean out the old binaries:

make bin-clean   or  rm lily/out/*

3) Update the snippets in Documentation/snippets from
Documentation/snippets/new:

scripts/auxiliar/makelsr.py

4) Build lilypond

make

5) Build docs

make doc-clean && make doc

This last process can be sped up with

make doc-clean && make -j3 CPU_COUNT=3 doc

if you have a dual-core processor.

This patch is ready for testing, but has a few small things remaining before
pushing:

A) Eliminate the commented debug lines in scm/auto-beam.scm

B) Update convert-rules.py (it currently has the changes for the last propose
syntax, and is aimed at release 2.13.24, which obviously didn't happen)

C) Add a note to changes.tely describing the new syntax.

Thanks,

Carl

[t.daniels_treda.co.uk, 2010-07-06 13:57:24]

Carl, you wrote Tuesday, July 06, 2010 3:55 AM


> OK, I've loaded patch set 2.  This patch set makes a clean doc 
> build.

Indeed it does.  Using the recipe below I now have your
patch applied to all binaries, libraries and docs.

Thanks.

Trevor

> To make this patch work, you'll need to do the following:
>
> 1) Apply the patch
>
> 2) Clean out the old binaries:
>
> make bin-clean   or  rm lily/out/*
>
> 3) Update the snippets in Documentation/snippets from
> Documentation/snippets/new:
>
> scripts/auxiliar/makelsr.py
>
> 4) Build lilypond
>
> make
>
> 5) Build docs
>
> make doc-clean && make doc
>
> This last process can be sped up with
>
> make doc-clean && make -j3 CPU_COUNT=3 doc
>
> if you have a dual-core processor.
>
> This patch is ready for testing, but has a few small things 
> remaining
> before pushing:
>
> A) Eliminate the commented debug lines in scm/auto-beam.scm
>
> B) Update convert-rules.py (it currently has the changes for the 
> last
> propose syntax, and is aimed at release 2.13.24, which obviously 
> didn't
> happen)
>
> C) Add a note to changes.tely describing the new syntax.
>
> Thanks,
>
> Carl
>
>
> http://codereview.appspot.com/1682049/show
>
> _______________________________________________
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/lilypond-devel
>
> 

[Neil Puttock, 2010-07-07 00:52:10]

Hi Carl,

This looks really good.

A few comments:

The regtests fail on beam-beat-grouping.ly, since it uses \setBeatGrouping to
set the obsolete property beamSettings.

The display method for \time is broken due to using ApplyContext (this is the
same problem as issue 765 for \ottava, which I'll post my patch for later);
you'll have to rework \time using a synthetic event so the properties are
visible (though this can wait for a separate patch).

Cheers,
Neil

http://codereview.appspot.com/1682049/diff/3035/9004
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1052
Documentation/notation/rhythms.itely:1052: In addition to setting the printed
time signature, the @code{time}
\time

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1055
Documentation/notation/rhythms.itely:1055: @code{baseUnit},
@code{beatStructure}, and @code{beamExceptions}.  The
baseMoment

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1069
Documentation/notation/rhythms.itely:1069: \overrideTimeSignatureSettings
Can you think of a better name which doesn't cause confusion with \override and
\revert (seeing as this naming convention will have to be changed)?

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1079
Documentation/notation/rhythms.itely:1079: For convenience, the Scheme function
@code{make-setting} is
`make-setting' is a bit vague

why not simply add these settings as extra arguments to
\overrideTimeSignatureSettings?

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1817
Documentation/notation/rhythms.itely:1817: of the beam, e.g. @code{(1 . 16)}.
e.g.,

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1860
Documentation/notation/rhythms.itely:1860: \new Voice  = two {
Voice =

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1895
Documentation/notation/rhythms.itely:1895: % eliminate beamException that groups
beats 1,2 and 3,4
beam exception

1, 2
3, 4

http://codereview.appspot.com/1682049/diff/3035/9005
File Documentation/snippets/new/automatic-beam-subdivisions.ly (right):

http://codereview.appspot.com/1682049/diff/3035/9005#newcode13
Documentation/snippets/new/automatic-beam-subdivisions.ly:13: } % begin verbatim
remove

http://codereview.appspot.com/1682049/diff/3035/9009
File Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly
(right):

http://codereview.appspot.com/1682049/diff/3035/9009#newcode6
Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly:6: Beat
grouping within a bar is controlled by the context property
within a measure

http://codereview.appspot.com/1682049/diff/3035/9009#newcode29
Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly:29:
doctitle = "Conducting signs measure grouping signs"
rename file too (and references in selected snippets)

http://codereview.appspot.com/1682049/diff/3035/9012
File Documentation/snippets/new/sub-dividing-beams.ly (right):

http://codereview.appspot.com/1682049/diff/3035/9012#newcode8
Documentation/snippets/new/sub-dividing-beams.ly:8: sub-divided.  That is, the
three (or more) beams stretch unbroken over
subdivided

etc.

http://codereview.appspot.com/1682049/diff/3035/9012#newcode25
Documentation/snippets/new/sub-dividing-beams.ly:25: } % begin verbatim
remove

http://codereview.appspot.com/1682049/diff/3035/9016
File lily/auto-beam-engraver.cc (right):

http://codereview.appspot.com/1682049/diff/3035/9016#newcode545
lily/auto-beam-engraver.cc:545: "beamExceptions "
mixing tabs and spaces

http://codereview.appspot.com/1682049/diff/3035/9019
File lily/beaming-pattern.cc (right):

http://codereview.appspot.com/1682049/diff/3035/9019#newcode298
lily/beaming-pattern.cc:298: Moment (1, 4));
indent

http://codereview.appspot.com/1682049/diff/3035/9027
File python/convertrules.py (right):

http://codereview.appspot.com/1682049/diff/3035/9027#newcode3008
python/convertrules.py:3008: @rule ((2, 13, 24),
beamSettings and beatLength need convert rules

http://codereview.appspot.com/1682049/diff/3035/9030
File scm/define-context-properties.scm (right):

http://codereview.appspot.com/1682049/diff/3035/9030#newcode133
scm/define-context-properties.scm:133: (beamExceptions ,list? "alist of
exceptions to autobeam rules
Alist

http://codereview.appspot.com/1682049/diff/3035/9030#newcode135
scm/define-context-properties.scm:135: (beatStructure ,list? "List of
baseMoments that are combined
@code{baseMoment}s

http://codereview.appspot.com/1682049/diff/3035/9030#newcode444
scm/define-context-properties.scm:444: subdivided at baseMoment positions by
only drawing one beam over the beat.")
@code{baseMoment}

http://codereview.appspot.com/1682049/diff/3035/9030#newcode472
scm/define-context-properties.scm:472: (timeSignatureSettings ,pair? "A nested
alist of settings for
,cheap-list?

http://codereview.appspot.com/1682049/diff/3035/9032
File scm/lily-library.scm (right):

http://codereview.appspot.com/1682049/diff/3035/9032#newcode70
scm/lily-library.scm:70: (if (null? fraction)
indent

http://codereview.appspot.com/1682049/diff/3035/9032#newcode75
scm/lily-library.scm:75: (cons (ly:moment-main-numerator moment)
indent

http://codereview.appspot.com/1682049/diff/3035/9034
File scm/music-functions.scm (right):

http://codereview.appspot.com/1682049/diff/3035/9034#newcode536
scm/music-functions.scm:536: (define (make-time-settings context)
indent

http://codereview.appspot.com/1682049/diff/3035/9034#newcode546
scm/music-functions.scm:546: (beam-exceptions fraction time-signature-settings))
indent (or move back up to previous line)

http://codereview.appspot.com/1682049/diff/3035/9034#newcode547
scm/music-functions.scm:547: (new-measure-length  (ly:make-moment num den)))
(new-measure-length (ly:make-moment num den)))

http://codereview.appspot.com/1682049/diff/3035/9035
File scm/time-signature-settings.scm (right):

http://codereview.appspot.com/1682049/diff/3035/9035#newcode72
scm/time-signature-settings.scm:72: '(
indent

http://codereview.appspot.com/1682049/diff/3035/9035#newcode107
scm/time-signature-settings.scm:107: ((beamExceptions . (((end . (((1 . 16) . (4
4 4 4 4 4 4 4)))))))))
((end

http://codereview.appspot.com/1682049/diff/3035/9035#newcode167
scm/time-signature-settings.scm:167: ((baseUnit . (1 . 8))
baseMoment

http://codereview.appspot.com/1682049/diff/3035/9035#newcode173
scm/time-signature-settings.scm:173: ((baseUnit . (1 . 8))
baseMoment

http://codereview.appspot.com/1682049/diff/3035/9035#newcode183
scm/time-signature-settings.scm:183: "Get setting @code{my-symbol} for
@code{time-signature} from
indent

http://codereview.appspot.com/1682049/diff/3035/9035#newcode199
scm/time-signature-settings.scm:199: "Get baseUnit value for
@code{time-signature} from
@code{baseMoment}

http://codereview.appspot.com/1682049/diff/3035/9035#newcode213
scm/time-signature-settings.scm:213: (/ (* (car numerator) (cdr denominator))
indent

[Carl, 2010-07-07 05:53:33]

On 2010/07/07 00:52:10, Neil Puttock wrote:
> Hi Carl,
> 
> This looks really good.

Thanks!

> The regtests fail on beam-beat-grouping.ly, since it uses \setBeatGrouping to
> set the obsolete property beamSettings.

Dang!  I know I fixed that once, but maybe I did it after running makelsr.py,
and I didn't backport that fix.

> 
> The display method for \time is broken due to using ApplyContext (this is the
> same problem as issue 765 for \ottava, which I'll post my patch for later);
> you'll have to rework \time using a synthetic event so the properties are
> visible (though this can wait for a separate patch).

Yes, I have that on my to-do list.  I think waiting for a separate patch makes
sense.  I'd love to see your patch for \ottava to help me get this right.

Thanks for your thorough review!

Carl

[Carl, 2010-07-07 05:55:07]

I've responded to each of Neil's comments below.  I'll post another patch set
once I've proven that the regtests and the docs build properly.

THanks,

Carl

http://codereview.appspot.com/1682049/diff/3035/9004
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1052
Documentation/notation/rhythms.itely:1052: In addition to setting the printed
time signature, the @code{time}
On 2010/07/07 00:52:10, Neil Puttock wrote:
> \time

Done.

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1055
Documentation/notation/rhythms.itely:1055: @code{baseUnit},
@code{beatStructure}, and @code{beamExceptions}.  The
On 2010/07/07 00:52:10, Neil Puttock wrote:
> baseMoment

Done.

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1069
Documentation/notation/rhythms.itely:1069: \overrideTimeSignatureSettings
On 2010/07/07 00:52:10, Neil Puttock wrote:
> Can you think of a better name which doesn't cause confusion with \override
and
> \revert 


We had a big discussion about this on -devel, and nobody came up with anything
that was better than the chosen names.  You can see the whole messy string here:

http://thread.gmane.org/gmane.comp.gnu.lilypond.devel/26649

If you have any better suggestions, I'd welcome them.


> (seeing as this naming convention will have to be changed)?

What does this mean?

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1079
Documentation/notation/rhythms.itely:1079: For convenience, the Scheme function
@code{make-setting} is
On 2010/07/07 00:52:10, Neil Puttock wrote:
> `make-setting' is a bit vague

Yes, it is.  Thanks for the catch. 

> 
> why not simply add these settings as extra arguments to
> \overrideTimeSignatureSettings?

I think the reason is that I wanted to separate out the constructor and accessor
functions for the settings.  But I can do that internally to the function call. 
No need to make the user do the extra call.

Oh, as I was editing the changes I remembered why I did it.  It was to be
similar to \override and \revert.

\override 'mygrob #'Property = Setting
\revert  'mygrob #'Property

Similarly

\overrideTimeSignatureSettings 'Voice #'(4 . 4) my-setting
\revertTimeSignatureSettings 'Voice #'(4 . 4) 

But I've gone ahead and made the changes so that we can see it both ways (and it
will be easy to revert if desired).

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1817
Documentation/notation/rhythms.itely:1817: of the beam, e.g. @code{(1 . 16)}.
On 2010/07/07 00:52:10, Neil Puttock wrote:
> e.g.,

Done.

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1860
Documentation/notation/rhythms.itely:1860: \new Voice  = two {
On 2010/07/07 00:52:10, Neil Puttock wrote:
> Voice =

Done.

http://codereview.appspot.com/1682049/diff/3035/9004#newcode1895
Documentation/notation/rhythms.itely:1895: % eliminate beamException that groups
beats 1,2 and 3,4
On 2010/07/07 00:52:10, Neil Puttock wrote:
> beam exception
> 
> 1, 2
> 3, 4

Done.

http://codereview.appspot.com/1682049/diff/3035/9005
File Documentation/snippets/new/automatic-beam-subdivisions.ly (right):

http://codereview.appspot.com/1682049/diff/3035/9005#newcode13
Documentation/snippets/new/automatic-beam-subdivisions.ly:13: } % begin verbatim
On 2010/07/07 00:52:10, Neil Puttock wrote:
> remove

Done.

http://codereview.appspot.com/1682049/diff/3035/9009
File Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly
(right):

http://codereview.appspot.com/1682049/diff/3035/9009#newcode6
Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly:6: Beat
grouping within a bar is controlled by the context property
On 2010/07/07 00:52:10, Neil Puttock wrote:
> within a measure

Done.

http://codereview.appspot.com/1682049/diff/3035/9009#newcode29
Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly:29:
doctitle = "Conducting signs measure grouping signs"
On 2010/07/07 00:52:10, Neil Puttock wrote:
> rename file too (and references in selected snippets)

This was actually a mistake; I didn't get rid of the comma on purpose.

I'm not a fan of the title of this snippet.  Read calls them "conducting signs";
Stone calls them "beating signs", and indicates that they are a subset of
"Conductor's signs".  Ross makes no mention that I can see.

Do you really want me to rename the file, or was that just for consistency?  My
current fix is to add the comma back in.

http://codereview.appspot.com/1682049/diff/3035/9012
File Documentation/snippets/new/sub-dividing-beams.ly (right):

http://codereview.appspot.com/1682049/diff/3035/9012#newcode8
Documentation/snippets/new/sub-dividing-beams.ly:8: sub-divided.  That is, the
three (or more) beams stretch unbroken over
On 2010/07/07 00:52:10, Neil Puttock wrote:
> subdivided
> 
> etc.

I wanted to rename this file, so I did
(Documentation/snippets/new/subdividing-beams.ly).  I al

What do I do to get rid of the old name in Documentation/snippets?  Do 
I make Documentation/snippets/new/sub-dividing-beams.ly with a markup
that says "THis snippet has been renamed"?

http://codereview.appspot.com/1682049/diff/3035/9012#newcode25
Documentation/snippets/new/sub-dividing-beams.ly:25: } % begin verbatim
On 2010/07/07 00:52:10, Neil Puttock wrote:
> remove

Done.

http://codereview.appspot.com/1682049/diff/3035/9016
File lily/auto-beam-engraver.cc (right):

http://codereview.appspot.com/1682049/diff/3035/9016#newcode545
lily/auto-beam-engraver.cc:545: "beamExceptions "
On 2010/07/07 00:52:10, Neil Puttock wrote:
> mixing tabs and spaces

Done.

http://codereview.appspot.com/1682049/diff/3035/9019
File lily/beaming-pattern.cc (right):

http://codereview.appspot.com/1682049/diff/3035/9019#newcode298
lily/beaming-pattern.cc:298: Moment (1, 4));
On 2010/07/07 00:52:10, Neil Puttock wrote:
> indent

Done.

http://codereview.appspot.com/1682049/diff/3035/9027
File python/convertrules.py (right):

http://codereview.appspot.com/1682049/diff/3035/9027#newcode3008
python/convertrules.py:3008: @rule ((2, 13, 24),
On 2010/07/07 00:52:10, Neil Puttock wrote:
> beamSettings and beatLength need convert rules

Yes, and we need to change the version to which the rules will apply.  I guess
it will be 2.13.28, now that .27 is out and Graham will be gone for a month.

http://codereview.appspot.com/1682049/diff/3035/9030
File scm/define-context-properties.scm (right):

http://codereview.appspot.com/1682049/diff/3035/9030#newcode133
scm/define-context-properties.scm:133: (beamExceptions ,list? "alist of
exceptions to autobeam rules
On 2010/07/07 00:52:10, Neil Puttock wrote:
> Alist

Changed to "An alist"

http://codereview.appspot.com/1682049/diff/3035/9030#newcode135
scm/define-context-properties.scm:135: (beatStructure ,list? "List of
baseMoments that are combined
On 2010/07/07 00:52:10, Neil Puttock wrote:
> @code{baseMoment}s

Done.

http://codereview.appspot.com/1682049/diff/3035/9030#newcode444
scm/define-context-properties.scm:444: subdivided at baseMoment positions by
only drawing one beam over the beat.")
On 2010/07/07 00:52:10, Neil Puttock wrote:
> @code{baseMoment}
> 

Done.

http://codereview.appspot.com/1682049/diff/3035/9030#newcode472
scm/define-context-properties.scm:472: (timeSignatureSettings ,pair? "A nested
alist of settings for
On 2010/07/07 00:52:10, Neil Puttock wrote:
> ,cheap-list?

Yep, done.

http://codereview.appspot.com/1682049/diff/3035/9032
File scm/lily-library.scm (right):

http://codereview.appspot.com/1682049/diff/3035/9032#newcode70
scm/lily-library.scm:70: (if (null? fraction)
On 2010/07/07 00:52:10, Neil Puttock wrote:
> indent

Done.

http://codereview.appspot.com/1682049/diff/3035/9032#newcode75
scm/lily-library.scm:75: (cons (ly:moment-main-numerator moment)
On 2010/07/07 00:52:10, Neil Puttock wrote:
> indent

Done.

http://codereview.appspot.com/1682049/diff/3035/9034
File scm/music-functions.scm (right):

http://codereview.appspot.com/1682049/diff/3035/9034#newcode536
scm/music-functions.scm:536: (define (make-time-settings context)
On 2010/07/07 00:52:10, Neil Puttock wrote:
> indent

Done.

http://codereview.appspot.com/1682049/diff/3035/9034#newcode546
scm/music-functions.scm:546: (beam-exceptions fraction time-signature-settings))
On 2010/07/07 00:52:10, Neil Puttock wrote:
> indent (or move back up to previous line)

Done.

http://codereview.appspot.com/1682049/diff/3035/9034#newcode547
scm/music-functions.scm:547: (new-measure-length  (ly:make-moment num den)))
On 2010/07/07 00:52:10, Neil Puttock wrote:
> (new-measure-length (ly:make-moment num den))) 

Done.

http://codereview.appspot.com/1682049/diff/3035/9035
File scm/time-signature-settings.scm (right):

http://codereview.appspot.com/1682049/diff/3035/9035#newcode72
scm/time-signature-settings.scm:72: '(
On 2010/07/07 00:52:10, Neil Puttock wrote:
> indent

Done.

http://codereview.appspot.com/1682049/diff/3035/9035#newcode107
scm/time-signature-settings.scm:107: ((beamExceptions . (((end . (((1 . 16) . (4
4 4 4 4 4 4 4)))))))))
On 2010/07/07 00:52:10, Neil Puttock wrote:
> ((end

Done.

http://codereview.appspot.com/1682049/diff/3035/9035#newcode167
scm/time-signature-settings.scm:167: ((baseUnit . (1 . 8))
On 2010/07/07 00:52:10, Neil Puttock wrote:
> baseMoment

Done.

http://codereview.appspot.com/1682049/diff/3035/9035#newcode173
scm/time-signature-settings.scm:173: ((baseUnit . (1 . 8))
On 2010/07/07 00:52:10, Neil Puttock wrote:
> baseMoment

Done.

http://codereview.appspot.com/1682049/diff/3035/9035#newcode183
scm/time-signature-settings.scm:183: "Get setting @code{my-symbol} for
@code{time-signature} from
On 2010/07/07 00:52:10, Neil Puttock wrote:
> indent

Done.

http://codereview.appspot.com/1682049/diff/3035/9035#newcode199
scm/time-signature-settings.scm:199: "Get baseUnit value for
@code{time-signature} from
On 2010/07/07 00:52:10, Neil Puttock wrote:
> @code{baseMoment}

Done.

http://codereview.appspot.com/1682049/diff/3035/9035#newcode213
scm/time-signature-settings.scm:213: (/ (* (car numerator) (cdr denominator))
On 2010/07/07 00:52:10, Neil Puttock wrote:
> indent

Done.

[Carl, 2010-07-07 17:47:19]

A new patch set has now been loaded.

[Neil Puttock, 2010-07-07 22:23:22]

On 2010/07/07 05:53:33, Carl wrote:

> Yes, I have that on my to-do list.  I think waiting for a separate patch makes
> sense.  I'd love to see your patch for \ottava to help me get this right.

I've just posted it here: http://codereview.appspot.com/1695052/show

I think you can follow a similar approach for \time, though it's a bit more
complicated since the parser's involved.

Cheers,

[Neil Puttock, 2010-07-07 22:40:48]

On 2010/07/07 05:55:07, Carl wrote:

> > (seeing as this naming convention will have to be changed)?
> 
> What does this mean?

I can't remember where I read it, but I was under the impression that once GLISS
starts, we'd have to think about deprecating the use of `override' and `revert'
as part of single commands (save for \overrideProperty of course)
 
> Do you really want me to rename the file, or was that just for consistency? 
My
> current fix is to add the comma back in.

I was just thinking of LSR migration once it has a version bump, but if you'd
like to improve the title, then go ahead.
 
> I wanted to rename this file, so I did
> (Documentation/snippets/new/subdividing-beams.ly).  I al
> 
> What do I do to get rid of the old name in Documentation/snippets?  Do 
> I make Documentation/snippets/new/sub-dividing-beams.ly with a markup
> that says "THis snippet has been renamed"?

No, just move the snippets, change the titles and emend the @lilypondfile
references.  Then you can do a local update.

Once a full update's done, the old names in
the snippet list files will be deleted (though you can delete them manually if
you prefer.)

Cheers,
Neil

[Neil Puttock, 2010-07-11 23:31:50]

Hi Carl,

LGTM.

The web snippet granados.ly uses beatLength, so will also need emending.

Cheers,
Neil

http://codereview.appspot.com/1682049/diff/35001/36004
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/1682049/diff/35001/36004#newcode1055
Documentation/notation/rhythms.itely:1055: predefined default values for these
values can be found in
for these properties

http://codereview.appspot.com/1682049/diff/35001/36004#newcode1060
Documentation/notation/rhythms.itely:1060: \score{
\score {

http://codereview.appspot.com/1682049/diff/35001/36004#newcode1730
Documentation/notation/rhythms.itely:1730: @funindex beamExceptions
+ beatStructure

http://codereview.appspot.com/1682049/diff/35001/36004#newcode1755
Documentation/notation/rhythms.itely:1755: for the beam type, use it to
determine the valid places where
beam-type ?

http://codereview.appspot.com/1682049/diff/35001/36004#newcode1824
Documentation/notation/rhythms.itely:1824: @emph{complete} exceptions list. 
That is, every exception that should
lists

http://codereview.appspot.com/1682049/diff/35001/36009
File Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly
(right):

http://codereview.appspot.com/1682049/diff/35001/36009#newcode16
Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly:16: the
measure.  @code{time} and @code{set-time-signature} both apply
@code{\time}

http://codereview.appspot.com/1682049/diff/35001/36009#newcode18
Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly:18:
@code{beatStructure} or @code{baseUnit} that are set in
baseMoment

http://codereview.appspot.com/1682049/diff/35001/36014
File input/regression/auto-beam-beaming-override.ly (right):

http://codereview.appspot.com/1682049/diff/35001/36014#newcode11
input/regression/auto-beam-beaming-override.ly:11: \version "2.13.27"
2.13.28

http://codereview.appspot.com/1682049/diff/35001/36016
File input/regression/beaming-ternary-metrum.ly (right):

http://codereview.appspot.com/1682049/diff/35001/36016#newcode2
input/regression/beaming-ternary-metrum.ly:2: \version "2.13.27"
2.13.28

http://codereview.appspot.com/1682049/diff/35001/36017
File input/regression/les-nereides.ly (right):

http://codereview.appspot.com/1682049/diff/35001/36017#newcode1
input/regression/les-nereides.ly:1: \version "2.13.27"
2.13.28

http://codereview.appspot.com/1682049/diff/35001/36019
File lily/beam-engraver.cc (right):

http://codereview.appspot.com/1682049/diff/35001/36019#newcode309
lily/beam-engraver.cc:309: "baseMoment ",
move to top

http://codereview.appspot.com/1682049/diff/35001/36025
File lily/timing-translator.cc (right):

http://codereview.appspot.com/1682049/diff/35001/36025#newcode62
lily/timing-translator.cc:62: context ()->set_property ("baseMoment",
add to translator doc (+ others missing)

http://codereview.appspot.com/1682049/diff/35001/36026
File ly/bagpipe.ly (right):

http://codereview.appspot.com/1682049/diff/35001/36026#newcode12
ly/bagpipe.ly:12: \version "2.13.27"
2.13.28

http://codereview.appspot.com/1682049/diff/35001/36027
File ly/engraver-init.ly (right):

http://codereview.appspot.com/1682049/diff/35001/36027#newcode19
ly/engraver-init.ly:19: \version "2.13.27"
2.13.28

http://codereview.appspot.com/1682049/diff/35001/36028
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/1682049/diff/35001/36028#newcode21
ly/music-functions-init.ly:21: \version "2.13.27"
2.13.28

http://codereview.appspot.com/1682049/diff/35001/36028#newcode675
ly/music-functions-init.ly:675: (revert-time-signature-setting time-signature
context))
indent

http://codereview.appspot.com/1682049/diff/35001/36030
File scm/auto-beam.scm (right):

http://codereview.appspot.com/1682049/diff/35001/36030#newcode62
scm/auto-beam.scm:62: (not (eq? (member moment beat-structure) #f)))
(pair? (member moment beat-structure))

http://codereview.appspot.com/1682049/diff/35001/36030#newcode127
scm/auto-beam.scm:127: ;; no rule applies, so end at beatLength or measure end
indent

http://codereview.appspot.com/1682049/diff/35001/36030#newcode129
scm/auto-beam.scm:129: ;; end if measure-pos matches a specified ending moment
indent

http://codereview.appspot.com/1682049/diff/35001/36037
File scm/time-signature-settings.scm (right):

http://codereview.appspot.com/1682049/diff/35001/36037#newcode253
scm/time-signature-settings.scm:253: (define (revert-property-setting context
property setting)
public?

http://codereview.appspot.com/1682049/diff/35001/36037#newcode270
scm/time-signature-settings.scm:270: time-signature setting . rest)
this indentation is unmaintainable

http://codereview.appspot.com/1682049/diff/35001/36037#newcode273
scm/time-signature-settings.scm:273: (context-spec-music
indent

http://codereview.appspot.com/1682049/diff/35001/36037#newcode287
scm/time-signature-settings.scm:287: time-signature setting 'Score))
move to previous line

[Carl, 2010-07-13 00:02:07]

On 2010/07/11 23:31:50, Neil Puttock wrote:
> Hi Carl,
> 
> LGTM.
> 
> The web snippet granados.ly uses beatLength, so will also need emending.
> 
> Cheers,
> Neil
> 

THanks for catching that, Neil.  I've fixed it as well (including updating the
version).

As soon as my make doc run is complete (assuming there are no errors), I'll post
another version of the patch.

[Carl, 2010-07-13 15:02:56]

Thanks for the careful review!

Carl

http://codereview.appspot.com/1682049/diff/35001/36004
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/1682049/diff/35001/36004#newcode1055
Documentation/notation/rhythms.itely:1055: predefined default values for these
values can be found in
On 2010/07/11 23:31:50, Neil Puttock wrote:
> for these properties

Done.

http://codereview.appspot.com/1682049/diff/35001/36004#newcode1060
Documentation/notation/rhythms.itely:1060: \score{
On 2010/07/11 23:31:50, Neil Puttock wrote:
> \score {

Done.

http://codereview.appspot.com/1682049/diff/35001/36004#newcode1730
Documentation/notation/rhythms.itely:1730: @funindex beamExceptions
On 2010/07/11 23:31:50, Neil Puttock wrote:
> + beatStructure

Done, + alphabetized the entries.

http://codereview.appspot.com/1682049/diff/35001/36004#newcode1755
Documentation/notation/rhythms.itely:1755: for the beam type, use it to
determine the valid places where
On 2010/07/11 23:31:50, Neil Puttock wrote:
> beam-type ?

I think not, because we're not talking about an argument to a function call or
an entry in an alist here.  We're talking about something that comes from the
music.  But I could be convinced otherwise.

http://codereview.appspot.com/1682049/diff/35001/36004#newcode1824
Documentation/notation/rhythms.itely:1824: @emph{complete} exceptions list. 
That is, every exception that should
On 2010/07/11 23:31:50, Neil Puttock wrote:
> lists

Changed to singular for all.  beamExceptions is now a context property, and
there is only *one* beamException value at any given time.

http://codereview.appspot.com/1682049/diff/35001/36009
File Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly
(right):

http://codereview.appspot.com/1682049/diff/35001/36009#newcode16
Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly:16: the
measure.  @code{time} and @code{set-time-signature} both apply
On 2010/07/11 23:31:50, Neil Puttock wrote:
> @code{\time}

Done.

http://codereview.appspot.com/1682049/diff/35001/36009#newcode18
Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly:18:
@code{beatStructure} or @code{baseUnit} that are set in
On 2010/07/11 23:31:50, Neil Puttock wrote:
> baseMoment

Done.

http://codereview.appspot.com/1682049/diff/35001/36014
File input/regression/auto-beam-beaming-override.ly (right):

http://codereview.appspot.com/1682049/diff/35001/36014#newcode11
input/regression/auto-beam-beaming-override.ly:11: \version "2.13.27"
On 2010/07/11 23:31:50, Neil Puttock wrote:
> 2.13.28

Done.

http://codereview.appspot.com/1682049/diff/35001/36016
File input/regression/beaming-ternary-metrum.ly (right):

http://codereview.appspot.com/1682049/diff/35001/36016#newcode2
input/regression/beaming-ternary-metrum.ly:2: \version "2.13.27"
On 2010/07/11 23:31:50, Neil Puttock wrote:
> 2.13.28

Done.

http://codereview.appspot.com/1682049/diff/35001/36017
File input/regression/les-nereides.ly (right):

http://codereview.appspot.com/1682049/diff/35001/36017#newcode1
input/regression/les-nereides.ly:1: \version "2.13.27"
On 2010/07/11 23:31:50, Neil Puttock wrote:
> 2.13.28

Done.

http://codereview.appspot.com/1682049/diff/35001/36019
File lily/beam-engraver.cc (right):

http://codereview.appspot.com/1682049/diff/35001/36019#newcode309
lily/beam-engraver.cc:309: "baseMoment ",
On 2010/07/11 23:31:50, Neil Puttock wrote:
> move to top

Done.

http://codereview.appspot.com/1682049/diff/35001/36025
File lily/timing-translator.cc (right):

http://codereview.appspot.com/1682049/diff/35001/36025#newcode62
lily/timing-translator.cc:62: context ()->set_property ("baseMoment",
On 2010/07/11 23:31:50, Neil Puttock wrote:
> add to translator doc (+ others missing)

Done.

http://codereview.appspot.com/1682049/diff/35001/36026
File ly/bagpipe.ly (right):

http://codereview.appspot.com/1682049/diff/35001/36026#newcode12
ly/bagpipe.ly:12: \version "2.13.27"
On 2010/07/11 23:31:50, Neil Puttock wrote:
> 2.13.28

Done.

http://codereview.appspot.com/1682049/diff/35001/36028
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/1682049/diff/35001/36028#newcode21
ly/music-functions-init.ly:21: \version "2.13.27"
On 2010/07/11 23:31:50, Neil Puttock wrote:
> 2.13.28

Done.

http://codereview.appspot.com/1682049/diff/35001/36028#newcode675
ly/music-functions-init.ly:675: (revert-time-signature-setting time-signature
context))
On 2010/07/11 23:31:50, Neil Puttock wrote:
> indent

Done.

http://codereview.appspot.com/1682049/diff/35001/36030
File scm/auto-beam.scm (right):

http://codereview.appspot.com/1682049/diff/35001/36030#newcode62
scm/auto-beam.scm:62: (not (eq? (member moment beat-structure) #f)))
On 2010/07/11 23:31:50, Neil Puttock wrote:
> (pair? (member moment beat-structure))

Oh, OK.  We return at least a single-item list if it's a member.

http://codereview.appspot.com/1682049/diff/35001/36030#newcode127
scm/auto-beam.scm:127: ;; no rule applies, so end at beatLength or measure end
On 2010/07/11 23:31:50, Neil Puttock wrote:
> indent

Done.

Also, changed the names to reflect exception groupings, and cleaned up the
comments to make them more clear, I hope.

http://codereview.appspot.com/1682049/diff/35001/36030#newcode129
scm/auto-beam.scm:129: ;; end if measure-pos matches a specified ending moment
On 2010/07/11 23:31:50, Neil Puttock wrote:
> indent

Done.

http://codereview.appspot.com/1682049/diff/35001/36037
File scm/time-signature-settings.scm (right):

http://codereview.appspot.com/1682049/diff/35001/36037#newcode253
scm/time-signature-settings.scm:253: (define (revert-property-setting context
property setting)
On 2010/07/11 23:31:50, Neil Puttock wrote:
> public?

Maybe I actually want to have neither one public.  I don't really want users
calling these routines.  What do you think?

http://codereview.appspot.com/1682049/diff/35001/36037#newcode270
scm/time-signature-settings.scm:270: time-signature setting . rest)
On 2010/07/11 23:31:50, Neil Puttock wrote:
> this indentation is unmaintainable

Done.

http://codereview.appspot.com/1682049/diff/35001/36037#newcode273
scm/time-signature-settings.scm:273: (context-spec-music
On 2010/07/11 23:31:50, Neil Puttock wrote:
> indent

Done.

Messed this up when I got rid of ly:export...

[Carl, 2010-07-13 15:05:00]

A new patch set has been uploaded.

Thanks,

Carl

[Neil Puttock, 2010-07-29 20:49:02]

On 2010/07/13 15:02:56, Carl wrote:

> On 2010/07/11 23:31:50, Neil Puttock wrote:
> > beam-type ?
> 
> I think not, because we're not talking about an argument to a function call or
> an entry in an alist here.  We're talking about something that comes from the
> music.  But I could be convinced otherwise.

I don't mind which, I was more concerned by the inconsistency: on the next line,
it says beam-type (and you use beam-type in the @itemize block above, *before*
you've presented the example for beaming rules which uses beam-type1, beam-type2
etc.)

[hamamatsu_gmx.de, 2010-08-01 16:33:50]

dear list,

i am *completely* confused by this autobeaming thing and especially its  
documentation.
even after reading it twice i do not have a clue how to practically use  
those things.
it rather appears as a highly complex mixture of *either* telling me what  
instructions and value exists *or* what they might contain *or* what  
changing them might have an effect, but i am completely lost in trying to  
combine that information.

and it seems it does not really cover my actual problem:

in a 8/32 measure, i am always having as a 9-tuplet (filling one measure)  
3 16th notes and one dotted 16th (in all possible orders). and i want  
always whole bar beams. which works fine unless the dotted 16th is first.
how do i change that?

Cheers, Arno

On Thu, 29 Jul 2010 22:49:02 +0200, <n.puttock@gmail.com> wrote:

> On 2010/07/13 15:02:56, Carl wrote:
>
>> On 2010/07/11 23:31:50, Neil Puttock wrote:
>> > beam-type ?
>
>> I think not, because we're not talking about an argument to a function
> call or
>> an entry in an alist here.  We're talking about something that comes
> from the
>> music.  But I could be convinced otherwise.
>
> I don't mind which, I was more concerned by the inconsistency: on the
> next line, it says beam-type (and you use beam-type in the @itemize
> block above, *before* you've presented the example for beaming rules
> which uses beam-type1, beam-type2 etc.)
>
> http://codereview.appspot.com/1682049/show
>
> _______________________________________________
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/lilypond-devel


-- 
Arno Waschk
+49-172-3149605
http://www.arnowaschk.de

upcoming projects:
Eggert: Bordellballade (WP) Dessau, Koblenz, Berlin
Schlingensief: Two new Projects (Burkina Faso, Brussels, Hamburg, Munich,  
Mühlheim/Ruhr, Berlin)
Maxwell-Davies/Sciarrino: Miss Donnithorne's Maggot/Infinito Nero Berlin  
Staatsoper

[c_sorensen, 2010-08-02 01:04:41]

On 8/1/10 10:33 AM, "Arno Waschk" <hamamatsu@gmx.de> wrote:

> dear list,
> 
> i am *completely* confused by this autobeaming thing and especially its
> documentation.
> even after reading it twice i do not have a clue how to practically use
> those things.
> it rather appears as a highly complex mixture of *either* telling me what
> instructions and value exists *or* what they might contain *or* what
> changing them might have an effect, but i am completely lost in trying to
> combine that information.
> 
> and it seems it does not really cover my actual problem:
> 
> in a 8/32 measure, i am always having as a 9-tuplet (filling one measure)
> 3 16th notes and one dotted 16th (in all possible orders). and i want
> always whole bar beams. which works fine unless the dotted 16th is first.
> how do i change that?

Do you want all durations of beams to be whole bar beams?  If so, simply do

\set beatStructure = #'(8)

Do you want only the tuplets to have whole bar beams, then you'll need to
set beamExceptions.  Probably something like

\set beamExceptions = #'((end . ((9 . 256) . (9))))

If you'd post code that shows what you've tried and what doesn't work, it
would be easier to help you.  And if there's a bug that is causing problems,
then it's easier to debug.

I'm sorry for your difficulties.  If you can get back with some examples,
I'll try to help (but I'm leaving tomorrow morning on my second week of
vacation).

Thanks,

Carl

[hamamatsu_gmx.de, 2010-08-02 07:43:53]

On Mon, 02 Aug 2010 03:04:35 +0200, Carl Sorensen <c_sorensen@byu.edu>  
wrote:

> On 8/1/10 10:33 AM, "Arno Waschk" <hamamatsu@gmx.de> wrote:
>
>> dear list,
>>
>> i am *completely* confused by this autobeaming thing and especially its
>> documentation.
>> even after reading it twice i do not have a clue how to practically use
>> those things.
>> it rather appears as a highly complex mixture of *either* telling me  
>> what
>> instructions and value exists *or* what they might contain *or* what
>> changing them might have an effect, but i am completely lost in trying  
>> to
>> combine that information.
>>
>> and it seems it does not really cover my actual problem:
>>
>> in a 8/32 measure, i am always having as a 9-tuplet (filling one  
>> measure)
>> 3 16th notes and one dotted 16th (in all possible orders). and i want
>> always whole bar beams. which works fine unless the dotted 16th is  
>> first.
>> how do i change that?
>
> Do you want all durations of beams to be whole bar beams?  If so, simply  
> do
>
> \set beatStructure = #'(8)

this is what i tried. does not work for the tuple thing.

>
> Do you want only the tuplets to have whole bar beams, then you'll need to
> set beamExceptions.  Probably something like
>
> \set beamExceptions = #'((end . ((9 . 256) . (9))))

i can try this, but now i understand even less than after reading the  
third time the docs....
why 256????

>
> If you'd post code that shows what you've tried and what doesn't work, it
> would be easier to help you.  And if there's a bug that is causing  
> problems,
> then it's easier to debug.
>
> I'm sorry for your difficulties.  If you can get back with some examples,

i would prefer to have docs with some clear explanation, which value has  
which effect. and some intuitive examples.
or even better the whole thing organised in a way which des not need pages  
of cryptic explanations....

Thanks, Arno

> I'll try to help (but I'm leaving tomorrow morning on my second week of
> vacation).
>
> Thanks,
>
> Carl
>


-- 
Arno Waschk
+49-172-3149605
http://www.arnowaschk.de

upcoming projects:
Eggert: Bordellballade (WP) Dessau, Koblenz, Berlin
Schlingensief: Two new Projects (Burkina Faso, Brussels, Hamburg, Munich,  
Mühlheim/Ruhr, Berlin)
Maxwell-Davies/Sciarrino: Miss Donnithorne's Maggot/Infinito Nero Berlin  
Staatsoper

[hamamatsu_gmx.de, 2010-08-02 07:47:50]

On Mon, 02 Aug 2010 09:43:48 +0200, Arno Waschk <hamamatsu@gmx.de> wrote:

> On Mon, 02 Aug 2010 03:04:35 +0200, Carl Sorensen <c_sorensen@byu.edu>  
> wrote:
>
>> On 8/1/10 10:33 AM, "Arno Waschk" <hamamatsu@gmx.de> wrote:
>>
>>> dear list,
>>>
>>> i am *completely* confused by this autobeaming thing and especially its
>>> documentation.
>>> even after reading it twice i do not have a clue how to practically use
>>> those things.


>>> in a 8/32 measure, i am always having as a 9-tuplet (filling one  
>>> measure)
>>> 3 16th notes and one dotted 16th (in all possible orders). and i want
>>> always whole bar beams. which works fine unless the dotted 16th is  
>>> first.
>>> how do i change that?
>>
>> Do you want all durations of beams to be whole bar beams?  If so,  
>> simply do
>>
>> \set beatStructure = #'(8)
>
> this is what i tried. does not work for the tuple thing.
>
>>
>> Do you want only the tuplets to have whole bar beams, then you'll need  
>> to
>> set beamExceptions.  Probably something like
>>
>> \set beamExceptions = #'((end . ((9 . 256) . (9))))
>
> i can try this, but now i understand even less than after reading the  
> third time the docs....
> why 256????

it gives:

/usr/local/share/lilypond/2.13.29/scm/auto-beam.scm:42:36: In procedure  
car in expression (car a):
/usr/local/share/lilypond/2.13.29/scm/auto-beam.scm:42:36: Wrong type  
(expecting pair): 9


>
>>
>> If you'd post code that shows what you've tried and what doesn't work,  
>> it
>> would be easier to help you.  And if there's a bug that is causing  
>> problems,
>> then it's easier to debug.
>>
>> I'm sorry for your difficulties.  If you can get back with some  
>> examples,
>
> i would prefer to have docs with some clear explanation, which value has  
> which effect. and some intuitive examples.
> or even better the whole thing organised in a way which des not need  
> pages of cryptic explanations....
>
> Thanks, Arno
>
>> I'll try to help (but I'm leaving tomorrow morning on my second week of
>> vacation).
>>
>> Thanks,
>>
>> Carl
>>
>
>


-- 
Arno Waschk
+49-172-3149605
http://www.arnowaschk.de

upcoming projects:
Eggert: Bordellballade (WP) Dessau, Koblenz, Berlin
Schlingensief: Two new Projects (Burkina Faso, Brussels, Hamburg, Munich,  
Mühlheim/Ruhr, Berlin)
Maxwell-Davies/Sciarrino: Miss Donnithorne's Maggot/Infinito Nero Berlin  
Staatsoper

[c_sorensen, 2010-08-02 12:40:05]

On 8/2/10 1:43 AM, "Arno Waschk" <hamamatsu@gmx.de> wrote:

> On Mon, 02 Aug 2010 03:04:35 +0200, Carl Sorensen <c_sorensen@byu.edu>
> wrote:
> 

>> 
>> Do you want all durations of beams to be whole bar beams?  If so, simply
>> do
>> 
>> \set beatStructure = #'(8)
> 
> this is what i tried. does not work for the tuple thing.

Then this is a bug.  An example would help.

> 
>> 
>> Do you want only the tuplets to have whole bar beams, then you'll need to
>> set beamExceptions.  Probably something like
>> 
>> \set beamExceptions = #'((end . ((9 . 256) . (9))))
> 
> i can try this, but now i understand even less than after reading the
> third time the docs....
> why 256????

Because I goofed and did 9/8 * 1/32 instead of 8/9 * 1/32.

The proper duration should have been (1 . 36).  I'm sorry for the confusion.

> 
>> 
>> If you'd post code that shows what you've tried and what doesn't work, it
>> would be easier to help you.  And if there's a bug that is causing
>> problems,
>> then it's easier to debug.
>> 
>> I'm sorry for your difficulties.  If you can get back with some examples,
> 
> i would prefer to have docs with some clear explanation, which value has
> which effect. and some intuitive examples.
> or even better the whole thing organised in a way which des not need pages
> of cryptic explanations....


I'd love to have some suggestions to improve things.  It's not like I'm
trying to require pages of cryptic explanations.....

Thanks,

Carl

[c_sorensen, 2010-08-02 12:44:02]

On 8/2/10 1:47 AM, "Arno Waschk" <hamamatsu@gmx.de> wrote:

> On Mon, 02 Aug 2010 09:43:48 +0200, Arno Waschk <hamamatsu@gmx.de> wrote:
> 
>> On Mon, 02 Aug 2010 03:04:35 +0200, Carl Sorensen <c_sorensen@byu.edu>
>> wrote:
>>> Do you want only the tuplets to have whole bar beams, then you'll need
>>> to
>>> set beamExceptions.  Probably something like
>>> 
>>> \set beamExceptions = #'((end . ((9 . 256) . (9))))
>> 
>> i can try this, but now i understand even less than after reading the
>> third time the docs....
>> why 256????
> 
> it gives:
> 
> /usr/local/share/lilypond/2.13.29/scm/auto-beam.scm:42:36: In procedure
> car in expression (car a):
> /usr/local/share/lilypond/2.13.29/scm/auto-beam.scm:42:36: Wrong type
> (expecting pair): 9

I'm sorry for my mistake.  It should have been

\set beamExceptions = #'((end . (((1 . 36) . (9)))))

I left out one level of parentheses.

Had there been sample code that didn't work, I'd have tried it out and found
my mistake.

Hence the importance of sample code when you're trying to get help from the
list.

Thanks,

Carl

[c_sorensen, 2010-08-02 13:00:25]

On 8/1/10 10:33 AM, "Arno Waschk" <hamamatsu@gmx.de> wrote:

> dear list,
> 
> i am *completely* confused by this autobeaming thing and especially its
> documentation.
> even after reading it twice i do not have a clue how to practically use
> those things.
> it rather appears as a highly complex mixture of *either* telling me what
> instructions and value exists *or* what they might contain *or* what
> changing them might have an effect, but i am completely lost in trying to
> combine that information.
> 
> and it seems it does not really cover my actual problem:
> 
> in a 8/32 measure, i am always having as a 9-tuplet (filling one measure)
> 3 16th notes and one dotted 16th (in all possible orders). and i want
> always whole bar beams. which works fine unless the dotted 16th is first.
> how do i change that?

The following produces whole bar beams on my system:

\version "2.13.29"
\relative c'' {
  \time 8/32
  \set beatStructure = #'(8)
  c32 c c c c c c c |
  \times 8/9 {c16. c32 c c c c c}
}


Thanks,

Carl