Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(971)

Issue 1682049: Revised autobeam settings patch (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by Carl
Modified:
13 years, 8 months ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Revised autobeam settings patch Eliminate context properties measureGrouping, beatLength, and beamSettings Create new context properties baseMoment, beatStructure, and beamExceptions. Save time-signature-specific settings in context property timeSignatureSettings Do away with virtually all special rules for beaming; the beat structure now governs almost all autobeaming. Fix documentation

Patch Set 1 : Revised autobeam patch #

Patch Set 2 : Clean Doc build #

Total comments: 62

Patch Set 3 : Respond to Neil's comments, fix convertrules.py #

Patch Set 4 : Fix convert-ly rules #

Total comments: 44

Patch Set 5 : Respond to Neil's latest comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1038 lines, -914 lines) Patch
M Documentation/de/notation/rhythms.itely View 1 2 3 4 10 chunks +36 lines, -35 lines 0 comments Download
M Documentation/es/notation/rhythms.itely View 1 2 3 4 7 chunks +28 lines, -26 lines 0 comments Download
M Documentation/fr/notation/rhythms.itely View 1 2 3 4 47 chunks +125 lines, -122 lines 0 comments Download
M Documentation/notation/rhythms.itely View 1 2 3 4 6 chunks +136 lines, -79 lines 0 comments Download
A Documentation/snippets/new/automatic-beam-subdivisions.ly View 2 1 chunk +39 lines, -0 lines 0 comments Download
M Documentation/snippets/new/beam-endings-in-score-context.ly View 1 2 3 chunks +6 lines, -10 lines 0 comments Download
M Documentation/snippets/new/beam-grouping-in-7-8-time.ly View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M Documentation/snippets/new/compound-time-signatures.ly View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly View 1 2 3 4 1 chunk +19 lines, -9 lines 0 comments Download
M Documentation/snippets/new/fretted-headword.ly View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M Documentation/snippets/new/reverting-default-beam-endings.ly View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
A Documentation/snippets/new/subdividing-beams.ly View 1 chunk +40 lines, -0 lines 0 comments Download
M Documentation/snippets/rhythms.snippet-list View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/web/ly-examples/granados.ly View 6 chunks +23 lines, -21 lines 0 comments Download
M input/regression/auto-beam-beaming-override.ly View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/beam-beat-grouping.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/beaming-ternary-metrum.ly View 1 2 3 4 2 chunks +6 lines, -8 lines 0 comments Download
M input/regression/les-nereides.ly View 1 2 3 4 2 chunks +3 lines, -4 lines 0 comments Download
M lily/auto-beam-engraver.cc View 1 2 7 chunks +27 lines, -27 lines 0 comments Download
M lily/beam-engraver.cc View 1 2 3 4 8 chunks +12 lines, -10 lines 0 comments Download
M lily/beam-setting-scheme.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M lily/beaming-pattern.cc View 1 2 4 chunks +9 lines, -8 lines 0 comments Download
M lily/include/beam-settings.hh View 1 chunk +0 lines, -29 lines 0 comments Download
M lily/include/beaming-pattern.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/measure-grouping-engraver.cc View 4 chunks +8 lines, -18 lines 0 comments Download
M lily/timing-translator.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M ly/bagpipe.ly View 1 2 3 4 3 chunks +15 lines, -17 lines 0 comments Download
M ly/engraver-init.ly View 2 chunks +12 lines, -2 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 3 4 4 chunks +16 lines, -50 lines 0 comments Download
M python/convertrules.py View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
M scm/auto-beam.scm View 1 2 3 4 2 chunks +77 lines, -55 lines 0 comments Download
M scm/beam-settings.scm View 1 chunk +0 lines, -240 lines 0 comments Download
M scm/define-context-properties.scm View 1 2 4 chunks +11 lines, -8 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/lily.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/lily-library.scm View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M scm/music-functions.scm View 1 2 2 chunks +28 lines, -26 lines 0 comments Download
A scm/time-signature-settings.scm View 1 2 3 4 1 chunk +299 lines, -0 lines 0 comments Download
M scripts/musicxml2ly.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24
Carl
I've posted a new patch for review that has the new autobeaming code. We now ...
13 years, 9 months ago (2010-07-05 05:23:40 UTC) #1
t.daniels_treda.co.uk
Hi Carl Download and applied to current git, but make fails: make[1]: *** No rule ...
13 years, 9 months ago (2010-07-05 08:07:41 UTC) #2
Carl
Apply on top of current git. But remember to do make bin-clean or rm lily/out/* ...
13 years, 9 months ago (2010-07-05 11:39:23 UTC) #3
t.daniels_treda.co.uk
Carl, you wrote Monday, July 05, 2010 12:39 PM > Apply on top of current ...
13 years, 8 months ago (2010-07-05 20:56:36 UTC) #4
Carl
OK, I've loaded patch set 2. This patch set makes a clean doc build. To ...
13 years, 8 months ago (2010-07-06 02:55:22 UTC) #5
t.daniels_treda.co.uk
Carl, you wrote Tuesday, July 06, 2010 3:55 AM > OK, I've loaded patch set ...
13 years, 8 months ago (2010-07-06 13:57:24 UTC) #6
Neil Puttock
Hi Carl, This looks really good. A few comments: The regtests fail on beam-beat-grouping.ly, since ...
13 years, 8 months ago (2010-07-07 00:52:10 UTC) #7
Carl
On 2010/07/07 00:52:10, Neil Puttock wrote: > Hi Carl, > > This looks really good. ...
13 years, 8 months ago (2010-07-07 05:53:33 UTC) #8
Carl
I've responded to each of Neil's comments below. I'll post another patch set once I've ...
13 years, 8 months ago (2010-07-07 05:55:07 UTC) #9
Carl
A new patch set has now been loaded.
13 years, 8 months ago (2010-07-07 17:47:19 UTC) #10
Neil Puttock
On 2010/07/07 05:53:33, Carl wrote: > Yes, I have that on my to-do list. I ...
13 years, 8 months ago (2010-07-07 22:23:22 UTC) #11
Neil Puttock
On 2010/07/07 05:55:07, Carl wrote: > > (seeing as this naming convention will have to ...
13 years, 8 months ago (2010-07-07 22:40:48 UTC) #12
Neil Puttock
Hi Carl, LGTM. The web snippet granados.ly uses beatLength, so will also need emending. Cheers, ...
13 years, 8 months ago (2010-07-11 23:31:50 UTC) #13
Carl
On 2010/07/11 23:31:50, Neil Puttock wrote: > Hi Carl, > > LGTM. > > The ...
13 years, 8 months ago (2010-07-13 00:02:07 UTC) #14
Carl
Thanks for the careful review! Carl http://codereview.appspot.com/1682049/diff/35001/36004 File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/1682049/diff/35001/36004#newcode1055 Documentation/notation/rhythms.itely:1055: predefined default values ...
13 years, 8 months ago (2010-07-13 15:02:56 UTC) #15
Carl
A new patch set has been uploaded. Thanks, Carl
13 years, 8 months ago (2010-07-13 15:05:00 UTC) #16
Neil Puttock
On 2010/07/13 15:02:56, Carl wrote: > On 2010/07/11 23:31:50, Neil Puttock wrote: > > beam-type ...
13 years, 8 months ago (2010-07-29 20:49:02 UTC) #17
hamamatsu_gmx.de
dear list, i am *completely* confused by this autobeaming thing and especially its documentation. even ...
13 years, 8 months ago (2010-08-01 16:33:50 UTC) #18
c_sorensen
On 8/1/10 10:33 AM, "Arno Waschk" <hamamatsu@gmx.de> wrote: > dear list, > > i am ...
13 years, 8 months ago (2010-08-02 01:04:41 UTC) #19
hamamatsu_gmx.de
On Mon, 02 Aug 2010 03:04:35 +0200, Carl Sorensen <c_sorensen@byu.edu> wrote: > On 8/1/10 10:33 ...
13 years, 8 months ago (2010-08-02 07:43:53 UTC) #20
hamamatsu_gmx.de
On Mon, 02 Aug 2010 09:43:48 +0200, Arno Waschk <hamamatsu@gmx.de> wrote: > On Mon, 02 ...
13 years, 8 months ago (2010-08-02 07:47:50 UTC) #21
c_sorensen
On 8/2/10 1:43 AM, "Arno Waschk" <hamamatsu@gmx.de> wrote: > On Mon, 02 Aug 2010 03:04:35 ...
13 years, 8 months ago (2010-08-02 12:40:05 UTC) #22
c_sorensen
On 8/2/10 1:47 AM, "Arno Waschk" <hamamatsu@gmx.de> wrote: > On Mon, 02 Aug 2010 09:43:48 ...
13 years, 8 months ago (2010-08-02 12:44:02 UTC) #23
c_sorensen
13 years, 8 months ago (2010-08-02 13:00:25 UTC) #24


On 8/1/10 10:33 AM, "Arno Waschk" <hamamatsu@gmx.de> wrote:

> dear list,
> 
> i am *completely* confused by this autobeaming thing and especially its
> documentation.
> even after reading it twice i do not have a clue how to practically use
> those things.
> it rather appears as a highly complex mixture of *either* telling me what
> instructions and value exists *or* what they might contain *or* what
> changing them might have an effect, but i am completely lost in trying to
> combine that information.
> 
> and it seems it does not really cover my actual problem:
> 
> in a 8/32 measure, i am always having as a 9-tuplet (filling one measure)
> 3 16th notes and one dotted 16th (in all possible orders). and i want
> always whole bar beams. which works fine unless the dotted 16th is first.
> how do i change that?

The following produces whole bar beams on my system:

\version "2.13.29"
\relative c'' {
  \time 8/32
  \set beatStructure = #'(8)
  c32 c c c c c c c |
  \times 8/9 {c16. c32 c c c c c}
}


Thanks,

Carl


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b