Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1436)

Issue 1695052: Fix #765: Display method for \ottava. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by Neil Puttock
Modified:
13 years, 8 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix #765: Display method for \ottava. Since \ottava currently uses ApplyContext to set the relevant context properties which trigger creation of an ottava bracket, the information useful to its display method (i.e., the octavation) is inaccessible: the only music property which can be extracted is the argument to ApplyContext, its procedure. By wrapping the existing code which creates an ottava bracket (make-ottava-set) in a synthetic event, the octavation can be passed as a music property, thus making it accessible from a display method. * input/regression/display-lily-tests.ly: add test for \ottava * ly/music-functions-init.ly (ottava): create ottava bracket via OttavaMusic, setting 'ottava-number * scm/define-music-display-methods.scm: add display method for \ottava, which simply catches OttavaMusic and reads 'ottava-number * scm/define-music-properties.scm (all-music-properties): add 'ottava-number * scm/define-music-types.scm: copy make-ottava-set from scm/music-functions.scm add OttavaMusic: uses a sequential iterator to call make-ottava-set via its elements-callback * scm/music-functions.scm: add ly:context-property as procedure-with-setter remove make-ottava-set

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -28 lines) Patch
M input/regression/display-lily-tests.ly View 1 chunk +2 lines, -0 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +3 lines, -2 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 chunk +3 lines, -0 lines 0 comments Download
M scm/define-music-properties.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-music-types.scm View 2 chunks +24 lines, -0 lines 0 comments Download
M scm/music-functions.scm View 2 chunks +4 lines, -26 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b