Issue 167780044: code review 167780044: debug/elf: add power64 support along with relocation test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 167780044: code review 167780044: debug/elf: add power64 support along with relocation test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by iant

Modified:
10 years, 3 months ago

Reviewers:

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

debug/elf: add power64 support along with relocation test Backport of https://codereview.appspot.com/125910043 from the dev.power64 branch of the master repository.

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+233 lines, -1 line)			Patch
M	libgo/go/debug/elf/elf.go	View	1 chunk	+178 lines, -0 lines	0 comments	Download
M	libgo/go/debug/elf/file.go	View	3 chunks	+49 lines, -1 line	0 comments	Download
M	libgo/go/debug/elf/file_test.go	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	libgo/go/debug/elf/testdata/go-relocation-test-gcc482-ppc64le.obj	View	Binary file		0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

iant

Hello iant (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://gofrontend.googlecode.com/hg/

10 years, 3 months ago (2014-10-28 22:56:15 UTC) #1

iant

10 years, 3 months ago (2014-10-28 22:56:29 UTC) #2

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=21b8b46b67f2 ***

debug/elf: add power64 support along with relocation test

Backport of https://codereview.appspot.com/125910043 from the
dev.power64 branch of the master repository.

R=iant
CC=gofrontend-dev
https://codereview.appspot.com/167780044

Expand All Messages | Collapse All Messages