Issue 125910043: [dev.power64] code review 125910043: debug/elf: add power64 support along with relocation test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 125910043: [dev.power64] code review 125910043: debug/elf: add power64 support along with relocation test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by minux

Modified:
10 years, 3 months ago

Reviewers:
rsc

CC:
rsc, iant, golang-codereviews

Visibility:
Public.

Description

debug/elf: add power64 support along with relocation test

Patch Set 1 #

Patch Set 2 : diff -r 1129a4022aa64fa2fd3975bf67740eafb80ce526 https://code.google.com/p/go #

Patch Set 3 : diff -r 1129a4022aa64fa2fd3975bf67740eafb80ce526 https://code.google.com/p/go #

Patch Set 4 : diff -r 0cbf0c3bca7b580d49b212323fefcbfa99acfd56 https://code.google.com/p/go #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+233 lines, -1 line)			Patch
M	src/pkg/debug/elf/elf.go	View	1	1 chunk	+178 lines, -0 lines	0 comments	Download
M	src/pkg/debug/elf/file.go	View	1	3 chunks	+49 lines, -1 line	0 comments	Download
M	src/pkg/debug/elf/file_test.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
A	src/pkg/debug/elf/testdata/go-relocation-test-gcc482-ppc64le.obj	View	1	Binary file		0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 ...

10 years, 3 months ago (2014-08-09 08:21:44 UTC) #1

minux

10 years, 3 months ago (2014-08-12 03:43:37 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=aa14e21aefd8 ***

[dev.power64] debug/elf: add power64 support along with relocation test

LGTM=rsc
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/125910043

Expand All Messages | Collapse All Messages