Issue 153070043: code review 153070043: go.tools/dashboard/app: return specific error string on...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 153070043: code review 153070043: go.tools/dashboard/app: return specific error string on... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by adg

Modified:
10 years, 6 months ago

Reviewers:
bradfitz

CC:
golang-codereviews

Visibility:
Public.

Description

go.tools/dashboard/app: return specific error string on commit not found

Patch Set 1 #

Patch Set 2 : diff -r 0732e60486ac68f13059ec7d805e6c086299bb0a https://code.google.com/p/go.tools #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	dashboard/app/build/handler.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello bradfitz (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 6 months ago (2014-10-06 05:18:20 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=4afcf629723f&repo=tools *** go.tools/dashboard/app: return specific error string on commit not found TBR=bradfitz ...

10 years, 6 months ago (2014-10-06 05:29:07 UTC) #2

bradfitz

10 years, 6 months ago (2014-10-06 15:02:46 UTC) #3

Message was sent while issue was closed.

LGTM but I'd add a comment that this is a magic string

Otherwise somebody might change it to fmt.Sprintf("comment %q not found", hex)
and break the watcher.

Expand All Messages | Collapse All Messages