code review 153070043: go.tools/dashboard/app: return specific error string on...

dashboard/app/build/handler.go

 // Copyright 2011 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // +build appengine
 
 package build
 
 import (
         "bytes"
@@ skipping 29 matching lines @@
 //
 // This handler is used by a gobuilder process in -commit mode.
 func commitHandler(r *http.Request) (interface{}, error) {
         c := contextForRequest(r)
         com := new(Commit)
 
         if r.Method == "GET" {
                 com.PackagePath = r.FormValue("packagePath")
                 com.Hash = r.FormValue("hash")
                 if err := datastore.Get(c, com.Key(c), com); err != nil {
+                        if err == datastore.ErrNoSuchEntity {
+                                return nil, errors.New("Commit not found")
+                        }
                         return nil, fmt.Errorf("getting Commit: %v", err)
                 }
                 if com.Num == 0 {
                         // Corrupt state which shouldn't happen but does.
                         // Return an error so builders' commit loops will
                         // be willing to retry submitting this commit.
                         return nil, errors.New("in datastore with zero Num")
                 }
                 if com.Desc == "" || com.User == "" {
                         // Also shouldn't happen, but at least happened
@@ skipping 823 matching lines @@
         }
         for {
                 s = s[:max]
                 r, size := utf8.DecodeLastRuneInString(s)
                 if r != utf8.RuneError || size != 1 {
                         return s
                 }
                 max--
         }
 }