Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(675)

Issue 152970043: code review 152970043: misc/cgo/test: fail issue 7978 with clearer error when ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by rsc
Modified:
6 years ago
Reviewers:
iant
CC:
golang-codereviews, iant, r
Visibility:
Public.

Description

misc/cgo/test: fail issue 7978 with clearer error when GOTRACEBACK != 2 The test doesn't work with GOTRACEBACK != 2. Diagnose that failure mode.

Patch Set 1 #

Patch Set 2 : diff -r 1a6aa1230701397d08732d68ec13c9201b5dfb8f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1a6aa1230701397d08732d68ec13c9201b5dfb8f https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r bc0fe81c7252a5597bbc02c82f6a09f649c3e91e https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M misc/cgo/test/issue7978.go View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/
6 years ago (2014-10-03 20:28:13 UTC) #1
iant
https://codereview.appspot.com/152970043/diff/40001/misc/cgo/test/issue7978.go File misc/cgo/test/issue7978.go (right): https://codereview.appspot.com/152970043/diff/40001/misc/cgo/test/issue7978.go#newcode86 misc/cgo/test/issue7978.go:86: t.Fatalf("GOTRACEBACK must be 2") How about t.Skip?
6 years ago (2014-10-03 20:29:52 UTC) #2
rsc
https://codereview.appspot.com/152970043/diff/40001/misc/cgo/test/issue7978.go File misc/cgo/test/issue7978.go (right): https://codereview.appspot.com/152970043/diff/40001/misc/cgo/test/issue7978.go#newcode86 misc/cgo/test/issue7978.go:86: t.Fatalf("GOTRACEBACK must be 2") On 2014/10/03 20:29:52, iant wrote: ...
6 years ago (2014-10-03 20:31:16 UTC) #3
iant
LGTM
6 years ago (2014-10-03 20:32:18 UTC) #4
rsc
6 years ago (2014-10-03 20:42:20 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=b4f1ec3e4cc1 ***

misc/cgo/test: fail issue 7978 with clearer error when GOTRACEBACK != 2

The test doesn't work with GOTRACEBACK != 2.
Diagnose that failure mode.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews, r
https://codereview.appspot.com/152970043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b