Code review - Issue 152970043: code review 152970043: misc/cgo/test: fail issue 7978 with clearer error when ...https://codereview.appspot.com/2014-10-03T20:42:20+00:00rietveld
Message from unknown
2014-10-03T20:27:43+00:00rscurn:md5:c333e247cd27429f166fa4b32fffd817
Message from unknown
2014-10-03T20:27:58+00:00rscurn:md5:6d709ee2c01054b1fd226c4a3ffbcf1e
Message from unknown
2014-10-03T20:28:08+00:00rscurn:md5:07177b85d71bd194c5a045147008e115
Message from rsc@golang.org
2014-10-03T20:28:13+00:00rscurn:md5:a2c209d317a3267529e6a3a6c81c0a73
Hello golang-codereviews@googlegroups.com (cc: iant, r),
I'd like you to review this change to
https://code.google.com/p/go/
Message from iant@golang.org
2014-10-03T20:29:52+00:00ianturn:md5:8e64e0985b659a5f0fd85bb8a8002892
https://codereview.appspot.com/152970043/diff/40001/misc/cgo/test/issue7978.go
File misc/cgo/test/issue7978.go (right):
https://codereview.appspot.com/152970043/diff/40001/misc/cgo/test/issue7978.go#newcode86
misc/cgo/test/issue7978.go:86: t.Fatalf("GOTRACEBACK must be 2")
How about t.Skip?
Message from rsc@golang.org
2014-10-03T20:31:16+00:00rscurn:md5:ea5ef8f70d5ffb08a2fd61c92960359b
https://codereview.appspot.com/152970043/diff/40001/misc/cgo/test/issue7978.go
File misc/cgo/test/issue7978.go (right):
https://codereview.appspot.com/152970043/diff/40001/misc/cgo/test/issue7978.go#newcode86
misc/cgo/test/issue7978.go:86: t.Fatalf("GOTRACEBACK must be 2")
On 2014/10/03 20:29:52, iant wrote:
> How about t.Skip?
I'm a little worried about losing the test quietly if the run.bash script is broken.
Message from iant@golang.org
2014-10-03T20:32:18+00:00ianturn:md5:93449bc86243654857fa2641a1365bb1
LGTM
Message from unknown
2014-10-03T20:42:11+00:00rscurn:md5:c9a4c12718329d5a26b076b9ac4ef5d1
Message from rsc@golang.org
2014-10-03T20:42:20+00:00rscurn:md5:99278e4f4727a2db848610fdc8340edf
*** Submitted as https://code.google.com/p/go/source/detail?r=b4f1ec3e4cc1 ***
misc/cgo/test: fail issue 7978 with clearer error when GOTRACEBACK != 2
The test doesn't work with GOTRACEBACK != 2.
Diagnose that failure mode.
LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews, r
https://codereview.appspot.com/152970043