Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6217)

Issue 148360043: Issue 4142: Make skipTypesetting skip time signatures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by Dan Eble
Modified:
9 years, 6 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Setting Score.skipTypesetting used to defer creating a time signature rather than skip it entirely. With this change, the temporal placement of time signatures is not affected by Score.skipTypesetting. The effect is evident in a few regression tests that set Score.skipTypesetting at the beginning.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M lily/time-signature-engraver.cc View 2 chunks +22 lines, -17 lines 1 comment Download

Messages

Total messages: 2
Dan Eble
The problem was discovered while debugging https://codereview.appspot.com/143450043/ .
9 years, 6 months ago (2014-09-30 12:32:26 UTC) #1
dak
9 years, 6 months ago (2014-09-30 12:43:17 UTC) #2
https://codereview.appspot.com/148360043/diff/1/lily/time-signature-engraver.cc
File lily/time-signature-engraver.cc (right):

https://codereview.appspot.com/148360043/diff/1/lily/time-signature-engraver....
lily/time-signature-engraver.cc:63: reallocated in the same spot */
The comment is rubbish since the value is protected in the derived_mark
procedure and thus cannot get collected.  Of course, it was rubbish before, but
if we are changing the code anyway, we need not keep it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b