Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1527)

Issue 143450043: Issue 4127: allow mid-measure \time (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 12 months ago by Dan Eble
Modified:
4 years, 11 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

\time is now allowed in mid measure provided that \partial appears at the same timestep.

Patch Set 1 #

Patch Set 2 : Just kill the warning #

Total comments: 1

Patch Set 3 : Edit documentation #

Total comments: 1

Patch Set 4 : Warn about mid-measure \time without \partial #

Total comments: 4

Patch Set 5 #

Patch Set 6 : Warn about explicit time changes only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -101 lines) Patch
M Documentation/changes.tely View 1 chunk +10 lines, -0 lines 0 comments Download
M Documentation/notation/ancient.itely View 1 chunk +2 lines, -1 line 0 comments Download
M Documentation/notation/changing-defaults.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/rhythms.itely View 5 chunks +26 lines, -33 lines 0 comments Download
M input/regression/time-signature-midmeasure.ly View 1 chunk +34 lines, -15 lines 0 comments Download
A input/regression/time-signature-midmeasure-warning.ly View 1 chunk +15 lines, -0 lines 0 comments Download
M lily/partial-iterator.cc View 3 chunks +28 lines, -26 lines 0 comments Download
M lily/time-signature-engraver.cc View 5 chunks +25 lines, -12 lines 0 comments Download
M scm/define-context-properties.scm View 1 chunk +3 lines, -0 lines 0 comments Download
M scm/define-music-callbacks.scm View 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 19
Dan Eble
This is a simpler (easier to comprehend) change than what I proposed in http://article.gmane.org/gmane.comp.gnu.lilypond.bugs/39790 . ...
4 years, 12 months ago (2014-09-23 01:11:51 UTC) #1
dak
On 2014/09/23 01:11:51, Dan Eble wrote: > This is a simpler (easier to comprehend) change ...
4 years, 12 months ago (2014-09-23 14:17:11 UTC) #2
Dan Eble
On 2014/09/23 14:17:11, dak wrote: > \time 3/4 c2. \time 4/4 ... > > we ...
4 years, 12 months ago (2014-09-23 22:06:48 UTC) #3
Dan Eble
On 2014/09/23 14:17:11, dak wrote: > So I propose we junk the warning if we ...
4 years, 12 months ago (2014-09-24 05:17:12 UTC) #4
dak
nine.fierce.ballads@gmail.com writes: > On 2014/09/23 14:17:11, dak wrote: >> So I propose we junk the ...
4 years, 12 months ago (2014-09-24 16:00:14 UTC) #5
Dan Eble
On 2014/09/24 16:00:14, dak wrote: > I'm currently still working on GUILE2 stuff. Once I'm ...
4 years, 12 months ago (2014-09-24 23:36:32 UTC) #6
Dan Eble
This new patch set works for me. If you approve of it (take your time), ...
4 years, 11 months ago (2014-09-25 03:53:35 UTC) #7
dak
On 2014/09/25 03:53:35, Dan Eble wrote: > This new patch set works for me. If ...
4 years, 11 months ago (2014-09-25 09:46:32 UTC) #8
dak
https://codereview.appspot.com/143450043/diff/20001/input/regression/time-signature-midmeasure.ly File input/regression/time-signature-midmeasure.ly (right): https://codereview.appspot.com/143450043/diff/20001/input/regression/time-signature-midmeasure.ly#newcode5 input/regression/time-signature-midmeasure.ly:5: \\partial except in an anacrusis. \partial is an anacrusis ...
4 years, 11 months ago (2014-09-25 10:30:09 UTC) #9
Dan Eble
Documentation changes are ready for review. I didn't think much needed to be said. I ...
4 years, 11 months ago (2014-09-26 04:54:40 UTC) #10
Dan Eble
David, what do you think about adding a context property which \time sets when it ...
4 years, 11 months ago (2014-09-26 12:49:22 UTC) #11
dak
On 2014/09/26 12:49:22, Dan Eble wrote: > David, what do you think about adding a ...
4 years, 11 months ago (2014-09-26 13:15:30 UTC) #12
Dan Eble
Now there is a warning if \time is used mid-measure without \partial. Order is not ...
4 years, 11 months ago (2014-09-28 04:12:57 UTC) #13
dak
https://codereview.appspot.com/143450043/diff/60001/lily/time-signature-engraver.cc File lily/time-signature-engraver.cc (right): https://codereview.appspot.com/143450043/diff/60001/lily/time-signature-engraver.cc#newcode102 lily/time-signature-engraver.cc:102: if (!(scm_is_bool (partialBusy) && scm_is_true (partialBusy))) if (!to_boolean (get_property ...
4 years, 11 months ago (2014-09-28 06:33:12 UTC) #14
dak
dak@gnu.org writes: > You don't have the cause argument of time_signature_ available, however, > since ...
4 years, 11 months ago (2014-09-28 06:39:32 UTC) #15
dak
On 2014/09/28 06:33:12, dak wrote: > Uh, to answer your question: easy way: probably not ...
4 years, 11 months ago (2014-09-28 06:49:08 UTC) #16
dak
On 2014/09/28 06:49:08, dak wrote: > On 2014/09/28 06:33:12, dak wrote: > > > Uh, ...
4 years, 11 months ago (2014-09-28 10:27:34 UTC) #17
Dan Eble
Note to self: Manually test MIDI output for real scores.
4 years, 11 months ago (2014-09-30 12:37:22 UTC) #18
Dan Eble
4 years, 11 months ago (2014-10-08 03:54:07 UTC) #19
Now a warning is only issued when there is an event for the time change.  This
is the final draft, I hope.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b