Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1444)

Issue 14767043: code review 14767043: go.crypto/ssh: additional coverage of message unmarshaling (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by dfc
Modified:
5 years, 10 months ago
Reviewers:
hanwen-google
CC:
golang-dev, hanwen-google
Visibility:
Public.

Description

go.crypto/ssh: additional coverage of message unmarshaling

Patch Set 1 #

Patch Set 2 : diff -r 5ff5636e18c9 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 5ff5636e18c9 https://code.google.com/p/go.crypto #

Total comments: 5

Patch Set 4 : diff -r 5ff5636e18c9 https://code.google.com/p/go.crypto #

Total comments: 2

Patch Set 5 : diff -r 32844aa1ae54 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M ssh/messages_test.go View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 5
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto
5 years, 11 months ago (2013-10-17 00:35:14 UTC) #1
hanwen-google
LGTM modulo nits. https://codereview.appspot.com/14767043/diff/6001/ssh/messages_test.go File ssh/messages_test.go (right): https://codereview.appspot.com/14767043/diff/6001/ssh/messages_test.go#newcode87 ssh/messages_test.go:87: t.Fatalf("expected %T, got %T", want, err) ...
5 years, 11 months ago (2013-10-17 05:53:37 UTC) #2
dfc
PTAL. https://codereview.appspot.com/14767043/diff/6001/ssh/messages_test.go File ssh/messages_test.go (right): https://codereview.appspot.com/14767043/diff/6001/ssh/messages_test.go#newcode87 ssh/messages_test.go:87: t.Fatalf("expected %T, got %T", want, err) On 2013/10/17 ...
5 years, 11 months ago (2013-10-19 10:59:56 UTC) #3
hanwen-google
LGTM https://codereview.appspot.com/14767043/diff/11001/ssh/messages_test.go File ssh/messages_test.go (right): https://codereview.appspot.com/14767043/diff/11001/ssh/messages_test.go#newcode87 ssh/messages_test.go:87: t.Fatalf("got %T, got %T", want, err) flip args ...
5 years, 11 months ago (2013-10-22 00:38:41 UTC) #4
dfc
5 years, 11 months ago (2013-10-22 21:45:56 UTC) #5
*** Submitted as
https://code.google.com/p/go/source/detail?r=e3c12cab1b35&repo=crypto ***

go.crypto/ssh: additional coverage of message unmarshaling

R=golang-dev, hanwen
CC=golang-dev
https://codereview.appspot.com/14767043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b