code review 14767043: go.crypto/ssh: additional coverage of message unmarshaling

go.crypto/ssh: additional coverage of message unmarshaling

[dfc, 2013-10-17 00:35:14]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.crypto

[hanwen-google, 2013-10-17 05:53:37]

LGTM modulo nits.

https://codereview.appspot.com/14767043/diff/6001/ssh/messages_test.go
File ssh/messages_test.go (right):

https://codereview.appspot.com/14767043/diff/6001/ssh/messages_test.go#newcode87
ssh/messages_test.go:87: t.Fatalf("expected %T, got %T", want, err)
i've been taught to use the "got X want Y" format for Go code

https://codereview.appspot.com/14767043/diff/6001/ssh/messages_test.go#newcod...
ssh/messages_test.go:109: if got := err.Error(); want != got {
can you do a type conversion instead? It's less sensitive to formatting details.

[dfc, 2013-10-19 10:59:56]

PTAL.

https://codereview.appspot.com/14767043/diff/6001/ssh/messages_test.go
File ssh/messages_test.go (right):

https://codereview.appspot.com/14767043/diff/6001/ssh/messages_test.go#newcode87
ssh/messages_test.go:87: t.Fatalf("expected %T, got %T", want, err)
On 2013/10/17 05:53:37, hanwen-google wrote:
> i've been taught to use the "got X want Y" format for Go code 

Done.

https://codereview.appspot.com/14767043/diff/6001/ssh/messages_test.go#newcod...
ssh/messages_test.go:109: if got := err.Error(); want != got {
On 2013/10/17 05:53:37, hanwen-google wrote:
> can you do a type conversion instead? It's less sensitive to formatting
details.

Done.

https://codereview.appspot.com/14767043/diff/6001/ssh/messages_test.go#newcod...
ssh/messages_test.go:109: if got := err.Error(); want != got {
On 2013/10/17 05:53:37, hanwen-google wrote:
> can you do a type conversion instead? It's less sensitive to formatting
details.

PTAL.

[hanwen-google, 2013-10-22 00:38:41]

LGTM

https://codereview.appspot.com/14767043/diff/11001/ssh/messages_test.go
File ssh/messages_test.go (right):

https://codereview.appspot.com/14767043/diff/11001/ssh/messages_test.go#newco...
ssh/messages_test.go:87: t.Fatalf("got %T, got %T", want, err)
flip args too

https://codereview.appspot.com/14767043/diff/11001/ssh/messages_test.go#newco...
ssh/messages_test.go:90: t.Fatal("got %#v, got %#v", want, got)
idem

[dfc, 2013-10-22 21:45:56]

*** Submitted as
https://code.google.com/p/go/source/detail?r=e3c12cab1b35&repo=crypto ***

go.crypto/ssh: additional coverage of message unmarshaling

R=golang-dev, hanwen
CC=golang-dev
https://codereview.appspot.com/14767043