Issue 144650044: code review 144650044: net/http/httputil: ensure DumpRequestOut dumps all of Body

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 144650044: code review 144650044: net/http/httputil: ensure DumpRequestOut dumps all of Body (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by bradfitz

Modified:
10 years, 5 months ago

Reviewers:
r, gobot

CC:
golang-codereviews, r, adg

Visibility:
Public.

Description

net/http/httputil: ensure DumpRequestOut dumps all of Body Bodies larger than 8KB (the default bufio reader size) weren't being dumped. Force a read of the body so they're teed into the response buffer. Thanks to Steven Hartland for identifying the problem. Fixes Issue 8089

Patch Set 1 #

Patch Set 2 : diff -r 2e467bc60e64def06419194f48fe0d6c8b56765d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2e467bc60e64def06419194f48fe0d6c8b56765d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2e467bc60e64def06419194f48fe0d6c8b56765d https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r b0e30135710173e2af2140fc019d408bcd1b45ab https://go.googlecode.com/hg/ #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -3 lines)			Patch
	M	src/net/http/httputil/dump.go	View	1 2 3 4	1 chunk	+10 lines, -2 lines	0 comments	Download
	M	src/net/http/httputil/dump_test.go	View	1	3 chunks	+29 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-codereviews@googlegroups.com (cc: adg@golang.org, r@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 5 months ago (2014-09-30 18:19:13 UTC) #1

LGTM https://codereview.appspot.com/144650044/diff/60001/src/net/http/httputil/dump.go File src/net/http/httputil/dump.go (right): https://codereview.appspot.com/144650044/diff/60001/src/net/http/httputil/dump.go#newcode105 src/net/http/httputil/dump.go:105: // Ensure all the body is read otherwise ...

10 years, 5 months ago (2014-09-30 18:20:56 UTC) #2

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=d5330a8278e5 *** net/http/httputil: ensure DumpRequestOut dumps all of Body Bodies larger than ...

10 years, 5 months ago (2014-09-30 19:09:37 UTC) #3

gobot

10 years, 5 months ago (2014-09-30 19:22:17 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the plan9-amd64-aram builder.
See http://build.golang.org/log/2c8892d48ff531c98bad80e1610320b03b67d3be

Expand All Messages | Collapse All Messages