code review 144650044: net/http/httputil: ensure DumpRequestOut dumps all of Body

src/net/http/httputil/dump.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package httputil
 
 import (
         "bufio"
         "bytes"
         "errors"
@@ skipping 84 matching lines @@
         // with a dummy response.
         var buf bytes.Buffer // records the output
         pr, pw := io.Pipe()
         defer pr.Close()
         defer pw.Close()
         dr := &delegateReader{c: make(chan io.Reader)}
         // Wait for the request before replying with a dummy response:
         go func() {
                 req, err := http.ReadRequest(bufio.NewReader(pr))
                 if err == nil {
-                        // Ensure all the body is read otherwise we'll get

[r, 2014/09/30 18:20:56]

s/read/read;/

-                        // a partial dump.
+                        // Ensure all the body is read; otherwise
+                        // we'll get a partial dump.
                         io.Copy(ioutil.Discard, req.Body)
                         req.Body.Close()
                 }
                 dr.c <- strings.NewReader("HTTP/1.1 204 No Content\r\n\r\n")
         }()
 
         t := &http.Transport{
                 DisableKeepAlives: true,
                 Dial: func(net, addr string) (net.Conn, error) {
                         return &dumpConn{io.MultiWriter(&buf, pw), dr}, nil
@@ skipping 158 matching lines @@
         if err == errNoBody {
                 err = nil
         }
         resp.Body = save
         resp.ContentLength = savecl
         if err != nil {
                 return nil, err
         }
         return b.Bytes(), nil
 }