DescriptionPrevent direct charm id routes mis-firing.
The routeDirectCharmId is ONLY meant to handle the case of short, id-only urls
"jujucharms.com/precise/mysql". It assumes the viewmode (usually 'sidebar').
A fullscreen url was getting processed except that the viewmode was set to
sidebar. This caused contention between the routeDirectCharmId and the
routeView which would work like this
- routeDirectCharmId: "Render this charm id I found in the url in sidebar mode"
- routeView: "We've rendered crap, but that was sidebar so Render this charm
id found in fullscreen"
--Enter double dispatch
- routeDirectCharmId: "Hmm, we've got crap rendered, but it was fullscreen so
the viewmode has changed. Render this charm id in sidebar"
- routeView: "Stupid sidebar, this clearly says to render it in fullscreen
viewmode. Render it again."
What should happen is that the routeDirectCharmId realizes that the url has
more than a charmId in it and just bails out saying another route (routeView)
will handle it altogether.
QA: Just hit the url in the bug in your local branch and it should work
perfectly without artifacts.
https://code.launchpad.net/~rharding/juju-gui/dispatch-1235012/+merge/190199
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 1
Patch Set 2 : Prevent direct charm id routes mis-firing. #
MessagesTotal messages: 4
|