Prevent direct charm id routes mis-firing.

Prevent direct charm id routes mis-firing.

The routeDirectCharmId is ONLY meant to handle the case of short, id-only urls
"jujucharms.com/precise/mysql". It assumes the viewmode (usually 'sidebar').

A fullscreen url was getting processed except that the viewmode was set to
sidebar. This caused contention between the routeDirectCharmId and the
routeView which would work like this

- routeDirectCharmId: "Render this charm id I found in the url in sidebar mode"
- routeView: "We've rendered crap, but that was sidebar so Render this charm
id found in fullscreen"

--Enter double dispatch

- routeDirectCharmId: "Hmm, we've got crap rendered, but it was fullscreen so
the viewmode has changed. Render this charm id in sidebar"
- routeView: "Stupid sidebar, this clearly says to render it in fullscreen
viewmode. Render it again."

What should happen is that the routeDirectCharmId realizes that the url has
more than a charmId in it and just bails out saying another route (routeView)
will handle it altogether.

QA: Just hit the url in the bug in your local branch and it should work
perfectly without artifacts.

https://code.launchpad.net/~rharding/juju-gui/dispatch-1235012/+merge/190199

(do not edit description out of merge proposal)

[rharding, 2013-10-09 17:33:09]

Please take a look.

[rharding, 2013-10-09 17:34:04]

Comment added

https://codereview.appspot.com/14441054/diff/1/app/subapps/browser/browser.js
File app/subapps/browser/browser.js (right):

https://codereview.appspot.com/14441054/diff/1/app/subapps/browser/browser.js...
app/subapps/browser/browser.js:917: var viewmode = this.get('defaultViewmode');
Only moved this since the comment actually goes with the line below it.

[matthew.scott, 2013-10-09 18:55:53]

LGTM, thanks!

[rharding, 2013-10-09 19:05:36]

*** Submitted:

Prevent direct charm id routes mis-firing.

The routeDirectCharmId is ONLY meant to handle the case of short, id-only urls
"jujucharms.com/precise/mysql". It assumes the viewmode (usually 'sidebar').

A fullscreen url was getting processed except that the viewmode was set to
sidebar. This caused contention between the routeDirectCharmId and the
routeView which would work like this

- routeDirectCharmId: "Render this charm id I found in the url in sidebar mode"
- routeView: "We've rendered crap, but that was sidebar so Render this charm
id found in fullscreen"

--Enter double dispatch

- routeDirectCharmId: "Hmm, we've got crap rendered, but it was fullscreen so
the viewmode has changed. Render this charm id in sidebar"
- routeView: "Stupid sidebar, this clearly says to render it in fullscreen
viewmode. Render it again."

What should happen is that the routeDirectCharmId realizes that the url has
more than a charmId in it and just bails out saying another route (routeView)
will handle it altogether.

QA: Just hit the url in the bug in your local branch and it should work
perfectly without artifacts.

R=matthew.scott
CC=
https://codereview.appspot.com/14441054