Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 14430055: code review 14430055: go.crypto/ssh: cosmetic only spelling fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by jmpittman
Modified:
5 years, 11 months ago
Reviewers:
agl1, hanwen-google
CC:
agl1, hanwen-google, dfc, golang-dev, jpsugar
Visibility:
Public.

Description

go.crypto/ssh: cosmetic only spelling fixes

Patch Set 1 #

Patch Set 2 : diff -r 812c06b5a384 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 812c06b5a384 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 812c06b5a384 https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r 812c06b5a384 https://code.google.com/p/go.crypto #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M ssh/channel.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ssh/client.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ssh/client_auth.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssh/common.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssh/kex.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssh/server.go View 1 2 chunks +2 lines, -2 lines 2 comments Download
M ssh/session.go View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ssh/session_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssh/tcpip.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
jmpittman
Hello agl@golang.org, hanwen@google.com (cc: dave@cheney.net, golang-dev@googlegroups.com, jpsugar@google.com), I'd like you to review this change to ...
5 years, 11 months ago (2013-10-10 14:37:50 UTC) #1
jmpittman
Hello agl@golang.org, hanwen@google.com (cc: dave@cheney.net, golang-dev@googlegroups.com, jpsugar@google.com), Please take another look.
5 years, 11 months ago (2013-10-10 14:38:28 UTC) #2
hanwen-google
LGTM https://codereview.appspot.com/14430055/diff/5002/ssh/server.go File ssh/server.go (left): https://codereview.appspot.com/14430055/diff/5002/ssh/server.go#oldcode38 ssh/server.go:38: // key authentication. It must return true iff ...
5 years, 11 months ago (2013-10-10 14:57:58 UTC) #3
jmpittman
https://codereview.appspot.com/14430055/diff/5002/ssh/server.go File ssh/server.go (left): https://codereview.appspot.com/14430055/diff/5002/ssh/server.go#oldcode38 ssh/server.go:38: // key authentication. It must return true iff the ...
5 years, 11 months ago (2013-10-10 15:17:17 UTC) #4
agl1
LGTM. I do use iff for "if, and only if,", but it's not important.
5 years, 11 months ago (2013-10-10 15:34:12 UTC) #5
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=7fb39a59524c&repo=crypto *** go.crypto/ssh: cosmetic only spelling fixes R=agl, hanwen CC=dave, golang-dev, jpsugar ...
5 years, 11 months ago (2013-10-10 15:35:20 UTC) #6
hanwen-google
5 years, 11 months ago (2013-10-10 15:35:50 UTC) #7
On Thu, Oct 10, 2013 at 5:17 PM,  <jmpittman@google.com> wrote:
>
> https://codereview.appspot.com/14430055/diff/5002/ssh/server.go
> File ssh/server.go (left):
>
> https://codereview.appspot.com/14430055/diff/5002/ssh/server.go#oldcode38
> ssh/server.go:38: // key authentication. It must return true iff the
> given public key is
> I was unaware of "iff" usage.  I see it now.
> http://en.wikipedia.org/wiki/If_and_only_if
>
> If it is desired to keep the "if and only if" meaning, I would prefer
> spelling it out completely.
>
> https://codereview.appspot.com/14430055/

I think it's OK for devs to return false even if the user is allowed
to log-in. SSH would simply not let the user in. I doubt anyone would
be surprised :)

-- 
Han-Wen Nienhuys
Google Munich
hanwen@google.com
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b