code review 14430055: go.crypto/ssh: cosmetic only spelling fixes

go.crypto/ssh: cosmetic only spelling fixes

[jmpittman, 2013-10-10 14:37:50]

Hello agl@golang.org, hanwen@google.com (cc: dave@cheney.net,
golang-dev@googlegroups.com, jpsugar@google.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[jmpittman, 2013-10-10 14:38:28]

Hello agl@golang.org, hanwen@google.com (cc: dave@cheney.net,
golang-dev@googlegroups.com, jpsugar@google.com),

Please take another look.

[hanwen-google, 2013-10-10 14:57:58]

LGTM

https://codereview.appspot.com/14430055/diff/5002/ssh/server.go
File ssh/server.go (left):

https://codereview.appspot.com/14430055/diff/5002/ssh/server.go#oldcode38
ssh/server.go:38: // key authentication. It must return true iff the given
public key is
Not sure if this is a typo; iff often means "if and only if", but I don't think
your correction detracts from clarity.

[jmpittman, 2013-10-10 15:17:17]

https://codereview.appspot.com/14430055/diff/5002/ssh/server.go
File ssh/server.go (left):

https://codereview.appspot.com/14430055/diff/5002/ssh/server.go#oldcode38
ssh/server.go:38: // key authentication. It must return true iff the given
public key is
I was unaware of "iff" usage.  I see it now. 
http://en.wikipedia.org/wiki/If_and_only_if

If it is desired to keep the "if and only if" meaning, I would prefer spelling
it out completely.

[agl1, 2013-10-10 15:34:12]

LGTM.

I do use iff for "if, and only if,", but it's not important.

[agl1, 2013-10-10 15:35:20]

*** Submitted as
https://code.google.com/p/go/source/detail?r=7fb39a59524c&repo=crypto ***

go.crypto/ssh: cosmetic only spelling fixes

R=agl, hanwen
CC=dave, golang-dev, jpsugar
https://codereview.appspot.com/14430055

Committer: Adam Langley <agl@golang.org>

[hanwen-google, 2013-10-10 15:35:50]

On Thu, Oct 10, 2013 at 5:17 PM,  <jmpittman@google.com> wrote:
>
> https://codereview.appspot.com/14430055/diff/5002/ssh/server.go
> File ssh/server.go (left):
>
> https://codereview.appspot.com/14430055/diff/5002/ssh/server.go#oldcode38
> ssh/server.go:38: // key authentication. It must return true iff the
> given public key is
> I was unaware of "iff" usage.  I see it now.
> http://en.wikipedia.org/wiki/If_and_only_if
>
> If it is desired to keep the "if and only if" meaning, I would prefer
> spelling it out completely.
>
> https://codereview.appspot.com/14430055/

I think it's OK for devs to return false even if the user is allowed
to log-in. SSH would simply not let the user in. I doubt anyone would
be surprised :)

-- 
Han-Wen Nienhuys
Google Munich
hanwen@google.com