Issue 14419052: code review 14419052: freetype/truetype: set the four phantom points, and adj...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14419052: code review 14419052: freetype/truetype: set the four phantom points, and adj... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by nigeltao

Modified:
10 years, 8 months ago

Reviewers:
bsiegert

CC:
bsiegert, golang-dev

Visibility:
Public.

Description

freetype/truetype: set the four phantom points, and adjust the glyph points accordingly. Yes, it's a mess, but let's pass the tests first, and then refactor.

Patch Set 2 : diff -r 00d9ad1a50a7 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 00d9ad1a50a7 https://code.google.com/p/freetype-go #

Total comments: 2

Patch Set 4 : diff -r 00d9ad1a50a7 https://code.google.com/p/freetype-go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -70 lines)			Patch
M	freetype/truetype/glyph.go	View	1 2 3	8 chunks	+117 lines, -58 lines	0 comments	Download
M	freetype/truetype/hint.go	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	freetype/truetype/truetype.go	View	1	1 chunk	+16 lines, -7 lines	0 comments	Download
M	freetype/truetype/truetype_test.go	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

10 years, 8 months ago (2013-10-09 11:23:05 UTC) #1

bsiegert

LGTM I am not a big fan of the current code but yes, it can ...

10 years, 8 months ago (2013-10-09 16:05:23 UTC) #2

nigeltao

https://codereview.appspot.com/14419052/diff/6001/freetype/truetype/truetype_test.go File freetype/truetype/truetype_test.go (left): https://codereview.appspot.com/14419052/diff/6001/freetype/truetype/truetype_test.go#oldcode91 freetype/truetype/truetype_test.go:91: //{"x-inconsolata", 10, 0}, On 2013/10/09 16:05:23, bsiegert wrote: > ...

10 years, 8 months ago (2013-10-09 20:41:14 UTC) #3

nigeltao

10 years, 8 months ago (2013-10-09 20:43:45 UTC) #4

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=7387aedbdd4b ***

freetype/truetype: set the four phantom points, and adjust the glyph
points accordingly.

Yes, it's a mess, but let's pass the tests first, and then refactor.

R=bsiegert
CC=golang-dev
https://codereview.appspot.com/14419052

Expand All Messages | Collapse All Messages