freetype/truetype/hint.go - Issue 14419052: code review 14419052: freetype/truetype: set the four phantom points, and adj...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: freetype/truetype/hint.go

Issue 14419052: code review 14419052: freetype/truetype: set the four phantom points, and adj... (Closed)

Patch Set: diff -r 00d9ad1a50a7 https://code.google.com/p/freetype-go Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: freetype/truetype/hint.go

===================================================================

--- a/freetype/truetype/hint.go

+++ b/freetype/truetype/hint.go

@@ -96,9 +96,7 @@

}

func resetTwilightPoints(f *Font, p []Point) []Point {

- // TODO: the C Freetype code uses n+4 for the 4 phantom points, but a

- // comment there says "(do we need this?)". Do we need to use n+4 here?

- if n := int(f.maxTwilightPoints); n <= cap(p) {

+ if n := int(f.maxTwilightPoints) + 4; n <= cap(p) {

p = p[:n]

for i := range p {

p[i] = Point{}

« no previous file with comments | « freetype/truetype/glyph.go ('k') | freetype/truetype/truetype.go » ('j') | no next file with comments »