Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(782)

Issue 141700043: code review 141700043: fmt: fix allocation tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by josharian
Modified:
10 years, 6 months ago
Reviewers:
r, iant
CC:
r, golang-codereviews, khr
Visibility:
Public.

Description

fmt: fix allocation tests Converting an integer to an interface{} allocates as of CL 130240043. Fixes issue 8617.

Patch Set 1 #

Patch Set 2 : diff -r cbf74e78998fe564f7c8177543072eabd100c537 https://code.google.com/p/go #

Patch Set 3 : diff -r cbf74e78998fe564f7c8177543072eabd100c537 https://code.google.com/p/go #

Patch Set 4 : diff -r cbf74e78998fe564f7c8177543072eabd100c537 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/fmt/fmt_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
josharian
Hello r@golang.org (cc: golang-codereviews@googlegroups.com, khr@golang.org), I'd like you to review this change to https://code.google.com/p/go
10 years, 6 months ago (2014-09-18 16:43:55 UTC) #1
r
LGTM yup sigh
10 years, 6 months ago (2014-09-18 16:44:39 UTC) #2
josharian
*** Submitted as https://code.google.com/p/go/source/detail?r=0316cda6569c *** fmt: fix allocation tests Converting an integer to an interface{} ...
10 years, 6 months ago (2014-09-18 16:45:11 UTC) #3
iant
10 years, 6 months ago (2014-09-18 18:36:23 UTC) #4
Message was sent while issue was closed.
In principle escape analysis should be able to detect that the allocation is not
necessary.  If an interface argument does not escape, then we can use a stack
pointer for the value stored in the interface.  In this case we have a
[]interface{}, so we need to know both that the slice as a whole does not escape
and that none of the elements of the slice escape.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b