src/fmt/fmt_test.go - Issue 141700043: code review 141700043: fmt: fix allocation tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/fmt/fmt_test.go

Issue 141700043: code review 141700043: fmt: fix allocation tests (Closed)

Patch Set: diff -r cbf74e78998fe564f7c8177543072eabd100c537 https://code.google.com/p/go Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/fmt/fmt_test.go

===================================================================

--- a/src/fmt/fmt_test.go

+++ b/src/fmt/fmt_test.go

@@ -864,9 +864,9 @@

}{

{0, `Sprintf("")`, func() { Sprintf("") }},

{1, `Sprintf("xxx")`, func() { Sprintf("xxx") }},

- {1, `Sprintf("%x")`, func() { Sprintf("%x", 7) }},

+ {2, `Sprintf("%x")`, func() { Sprintf("%x", 7) }},

{2, `Sprintf("%s")`, func() { Sprintf("%s", "hello") }},

- {1, `Sprintf("%x %x")`, func() { Sprintf("%x %x", 7, 112) }},

+ {3, `Sprintf("%x %x")`, func() { Sprintf("%x %x", 7, 112) }},

{2, `Sprintf("%g")`, func() { Sprintf("%g", float32(3.14159)) }}, // TODO: Can this be 1?

{1, `Fprintf(buf, "%s")`, func() { mallocBuf.Reset(); Fprintf(&mallocBuf, "%s", "hello") }},

// If the interface value doesn't need to allocate, amortized allocation overhead should be zero.

« no previous file with comments | « no previous file | no next file » | no next file with comments »