Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(125)

Issue 139070043: code review 139070043: cmd/cgo, runtime: write cgo stub wrappers in Go, not C (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
gobot, brainman, iant
CC:
golang-codereviews, brainman, iant, dvyukov, khr, r
Visibility:
Public.

Description

cmd/cgo, runtime: write cgo stub wrappers in Go, not C

Patch Set 1 #

Patch Set 2 : diff -r bc9245d02338ac13d7b3ca552c6e0bbd87bba65d https://code.google.com/p/go/ #

Patch Set 3 : diff -r bc9245d02338ac13d7b3ca552c6e0bbd87bba65d https://code.google.com/p/go/ #

Total comments: 6

Patch Set 4 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://code.google.com/p/go/ #

Patch Set 5 : diff -r 36d3d8a7ae548d555044ebd4a146c49b751b9880 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -109 lines) Patch
M misc/cgo/test/callback.go View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M src/cmd/cgo/out.go View 1 2 9 chunks +116 lines, -102 lines 0 comments Download
M src/pkg/runtime/asm_386.s View 1 2 3 4 2 chunks +10 lines, -1 line 0 comments Download
M src/pkg/runtime/asm_amd64.s View 1 2 3 4 2 chunks +10 lines, -1 line 0 comments Download
M src/pkg/runtime/asm_amd64p32.s View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M src/pkg/runtime/asm_arm.s View 1 2 3 4 2 chunks +10 lines, -1 line 0 comments Download
M src/pkg/runtime/cgocall.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/cgocall.c View 1 2 chunks +10 lines, -1 line 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant, khr, r), I'd like you to review this change to ...
10 years, 6 months ago (2014-09-02 23:31:11 UTC) #1
brainman
https://codereview.appspot.com/139070043/diff/40001/misc/cgo/test/callback.go File misc/cgo/test/callback.go (right): https://codereview.appspot.com/139070043/diff/40001/misc/cgo/test/callback.go#newcode22 misc/cgo/test/callback.go:22: "./backdoor" Some missing files? https://codereview.appspot.com/139070043/diff/40001/src/pkg/runtime/asm_amd64.s File src/pkg/runtime/asm_amd64.s (right): https://codereview.appspot.com/139070043/diff/40001/src/pkg/runtime/asm_amd64.s#newcode769 ...
10 years, 6 months ago (2014-09-03 00:00:47 UTC) #2
rsc
PTAL https://codereview.appspot.com/139070043/diff/40001/misc/cgo/test/callback.go File misc/cgo/test/callback.go (right): https://codereview.appspot.com/139070043/diff/40001/misc/cgo/test/callback.go#newcode22 misc/cgo/test/callback.go:22: "./backdoor" On 2014/09/03 00:00:47, brainman wrote: > Some ...
10 years, 6 months ago (2014-09-03 00:38:06 UTC) #3
brainman
LGTM but you, probably, should wait for someone who knows more about cgo. Alex
10 years, 6 months ago (2014-09-03 01:04:57 UTC) #4
iant
LGTM
10 years, 6 months ago (2014-09-03 01:08:04 UTC) #5
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=1bc626afe666 *** cmd/cgo, runtime: write cgo stub wrappers in Go, not C ...
10 years, 6 months ago (2014-09-03 15:36:17 UTC) #6
gobot
10 years, 6 months ago (2014-09-03 15:45:24 UTC) #7
Message was sent while issue was closed.
This CL appears to have broken the linux-amd64-temp builder.
See http://build.golang.org/log/e8933eb15e41db3fc0690a291193cb947270113e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b