misc/cgo/test/callback.go - Issue 139070043: code review 139070043: cmd/cgo, runtime: write cgo stub wrappers in Go, not C

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: misc/cgo/test/callback.go

Issue 139070043: code review 139070043: cmd/cgo, runtime: write cgo stub wrappers in Go, not C (Closed)

Patch Set: diff -r 36d3d8a7ae548d555044ebd4a146c49b751b9880 https://code.google.com/p/go/ Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: misc/cgo/test/callback.go

===================================================================

--- a/misc/cgo/test/callback.go

+++ b/misc/cgo/test/callback.go

@@ -13,12 +13,13 @@

import "C"

import (

- "./backdoor"

"path"

"runtime"

"strings"

"testing"

"unsafe"

+ "./backdoor"

)

// nestedCall calls into C, back into Go, and finally to f.

@@ -155,8 +156,8 @@

"runtime.cgocallbackg1",

"runtime.cgocallbackg",

"runtime.cgocallback_gofunc",

- "runtime.asmcgocall",

- "runtime.cgocall",

+ "runtime.asmcgocall_errno",

+ "runtime.cgocall_errno",

"test._Cfunc_callback",

"test.nestedCall",

"test.testCallbackCallers",

« no previous file with comments | « no previous file | src/cmd/cgo/out.go » ('j') | no next file with comments »