Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1065)

Issue 13900044: Fix settings update in juju-core.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by frankban
Modified:
10 years, 7 months ago
Reviewers:
mp+187544
Visibility:
Public.

Description

Fix settings update in juju-core. When sending ServiceSet requests, the GUI included a Config parameter where juju-core expects an Option one. While I was looking at that code, I decided instead to switch to the newer ServiceUpdate API call, which handles both map[string]string and YAML settings. QA: - deploy and expose the GUI in a juju-core env; - switch to this branch: juju set juju-gui juju-gui-source=lp:~frankban/juju-gui/bug-1229939-service-set - try to change settings (e.g. juju-gui-debug); - refresh. The settings viewlet should reflect the changes and, after a while (after config-changed runs), the new settings should be applied. https://code.launchpad.net/~frankban/juju-gui/bug-1229939-service-set/+merge/187544 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -61 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/go.js View 1 chunk +10 lines, -10 lines 0 comments Download
M app/store/env/sandbox.js View 1 chunk +26 lines, -35 lines 0 comments Download
M test/test_env_go.js View 2 chunks +6 lines, -8 lines 0 comments Download
M test/test_inspector_settings.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_sandbox_go.js View 2 chunks +4 lines, -4 lines 0 comments Download
M test/test_service_config_view.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2
frankban
Please take a look.
10 years, 7 months ago (2013-09-25 15:44:07 UTC) #1
frankban
10 years, 7 months ago (2013-10-02 15:54:16 UTC) #2
This bug has been fixed here: https://codereview.appspot.com/13917043/ .
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b