Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15194)

Issue 13917043: Fix settings update in juju-core.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by frankban
Modified:
10 years, 7 months ago
Reviewers:
mp+187567, jeff.pihach
Visibility:
Public.

Description

Fix settings update in juju-core. When sending ServiceSet requests, the GUI included a Config parameter where juju-core expects an Option one. Also fixed the parameter name used in ServiceSetYAML. QA: - deploy and expose the GUI in a juju-core env; - switch to this branch: juju set juju-gui juju-gui-source=lp:~frankban/juju-gui/service-set-simple - try to change settings (e.g. juju-gui-debug); - refresh. The settings viewlet should reflect the changes and, after a while (after the config-changed hook execution), the new settings should be applied. https://code.launchpad.net/~frankban/juju-gui/service-set-simple/+merge/187567 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix settings update in juju-core. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/go.js View 1 chunk +2 lines, -2 lines 0 comments Download
M app/store/env/sandbox.js View 2 chunks +3 lines, -2 lines 0 comments Download
M test/test_env_go.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_inspector_settings.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_sandbox_go.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_service_config_view.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
10 years, 7 months ago (2013-09-25 17:12:18 UTC) #1
jeff.pihach
QA NO GOOD Using the charm: cs:precise/juju-gui-76 I switch to your branch I click the ...
10 years, 7 months ago (2013-09-26 14:44:57 UTC) #2
jeff.pihach
LGTM QA Ok after investigation of the issue (preexisting) Thanks!!
10 years, 7 months ago (2013-09-26 15:20:30 UTC) #3
frankban
10 years, 7 months ago (2013-09-26 15:27:33 UTC) #4
*** Submitted:

Fix settings update in juju-core.

When sending ServiceSet requests, the GUI included
a Config parameter where juju-core expects an
Option one. 

Also fixed the parameter name used in ServiceSetYAML.

QA:
- deploy and expose the GUI in a juju-core env;
- switch to this branch: 
    juju set juju-gui juju-gui-source=lp:~frankban/juju-gui/service-set-simple
- try to change settings (e.g. juju-gui-debug);
- refresh.

The settings viewlet should reflect the changes and,
after a while (after the config-changed hook execution), 
the new settings should be applied.

R=jeff.pihach
CC=
https://codereview.appspot.com/13917043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b