code review 137020043: cmd/cc: generate error if #pragma pack off does anything

cmd/cc: generate error if #pragma pack off does anything

We can't translate misaligned things to Go, so start rejecting them in C.

The only one in any build appears to be EpollEvent on linux/amd64.
Fix that.

[rsc, 2014-08-30 18:13:07]

Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant, r),

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2014-08-30 18:19:55]

LGTM

so long, hjdicks

[dvyukov, 2014-08-30 18:40:40]

waiting for this to update netpoll patch

[rsc, 2014-08-30 18:54:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=c31e69cab80b ***

cmd/cc: generate error if #pragma pack off does anything

We can't translate misaligned things to Go, so start rejecting them in C.

The only one in any build appears to be EpollEvent on linux/amd64.
Fix that.

LGTM=r
R=golang-codereviews, r, dvyukov
CC=golang-codereviews, iant
https://codereview.appspot.com/137020043

[gobot, 2014-08-30 19:03:27]

This CL appears to have broken the android-arm-crawshaw builder.
See http://build.golang.org/log/f34fec6ca8f4c8e356d2224fc0a9d44f12ae9402

[brainman, 2014-09-01 02:11:03]

On 2014/08/30 19:03:27, gobot wrote:
> This CL appears to have broken the android-arm-crawshaw builder.
> See http://build.golang.org/log/f34fec6ca8f4c8e356d2224fc0a9d44f12ae9402

This also fails on both 386 and amd64 windows builders with:

--- FAIL: TestCPUProfile (0.25s)
	pprof_test.go:95: profile too short: [0x0 0x3 0x0 0x2710 0x0 0x0 0x1 0x0]
FAIL
FAIL	runtime/pprof	7.621s

but I cannot reproduce it here. Suggestions are welcome.

Alex

[rsc, 2014-09-01 04:03:32]

On Sun, Aug 31, 2014 at 10:11 PM, <alex.brainman@gmail.com> wrote:

> This also fails on both 386 and amd64 windows builders with:
>
> --- FAIL: TestCPUProfile (0.25s)
>         pprof_test.go:95: profile too short: [0x0 0x3 0x0 0x2710 0x0 0x0
> 0x1
> 0x0]
> FAIL
> FAIL    runtime/pprof   7.621s
>

That's almost certainly https://codereview.appspot.com/133370043, not this
CL.

Russ

[dvyukov, 2014-09-01 07:33:06]

On Mon, Sep 1, 2014 at 6:11 AM,  <alex.brainman@gmail.com> wrote:
> On 2014/08/30 19:03:27, gobot wrote:
>>
>> This CL appears to have broken the android-arm-crawshaw builder.
>> See
>
> http://build.golang.org/log/f34fec6ca8f4c8e356d2224fc0a9d44f12ae9402
>
> This also fails on both 386 and amd64 windows builders with:
>
> --- FAIL: TestCPUProfile (0.25s)
>         pprof_test.go:95: profile too short: [0x0 0x3 0x0 0x2710 0x0 0x0 0x1
> 0x0]
> FAIL
> FAIL    runtime/pprof   7.621s
>
> but I cannot reproduce it here. Suggestions are welcome.
>
> Alex


Humm... I can't reproduce it on a windown machine as well. I
consistently get the following output, which looks perfectly ideal:

=== RUN TestCPUProfile
--- PASS: TestCPUProfile (0.25s)
pprof_test.go:165: runtime/pprof_test.cpuHog1: 24

I see that on the bot the test also runs for at least 0.25s, but there
are no samples at all...
Alex, if you can figure out what constants in cpuHogger will please
the windows bots, then we can just bump them.

[brainman, 2014-09-01 07:38:12]

On 2014/09/01 07:33:06, dvyukov wrote:
> Alex, if you can figure out what constants in cpuHogger will please
> the windows bots, ...

I will try to run these tests on our builders.

Alex

[brainman, 2014-09-01 11:36:42]

https://codereview.appspot.com/140110043/

Alex