code review 133370043: runtime/pprof: make CPU profiling tests more robust

runtime/pprof: make CPU profiling tests more robust
Under the race detector most of the samples go into race runtime,
because of that freebsd race builder constantly fails on this test.

[dvyukov, 2014-08-30 14:12:06]

Hello golang-codereviews@googlegroups.com (cc: minux@golang.org,
rsc@golang.org),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[bradfitz, 2014-08-30 17:01:18]

LGTM

https://codereview.appspot.com/133370043/diff/60001/src/pkg/runtime/pprof/ppr...
File src/pkg/runtime/pprof/pprof_test.go (right):

https://codereview.appspot.com/133370043/diff/60001/src/pkg/runtime/pprof/ppr...
src/pkg/runtime/pprof/pprof_test.go:31: for i := 0; i < 100 ||
time.Now().Sub(t0) < 250*time.Millisecond; i++ {
time.Since(t0)

https://codereview.appspot.com/133370043/diff/60001/src/pkg/runtime/pprof/ppr...
src/pkg/runtime/pprof/pprof_test.go:54: 
empty line not present in cpuHog2

[rsc, 2014-08-30 17:33:26]

LGTM

https://codereview.appspot.com/133370043/diff/60001/src/pkg/runtime/pprof/ppr...
File src/pkg/runtime/pprof/pprof_test.go (right):

https://codereview.appspot.com/133370043/diff/60001/src/pkg/runtime/pprof/ppr...
src/pkg/runtime/pprof/pprof_test.go:27: // But do at least 500 iterations (which
should take about 100ms),
The comment says 500 but the code says 100.

[dvyukov, 2014-08-30 18:36:08]

https://codereview.appspot.com/133370043/diff/60001/src/pkg/runtime/pprof/ppr...
File src/pkg/runtime/pprof/pprof_test.go (right):

https://codereview.appspot.com/133370043/diff/60001/src/pkg/runtime/pprof/ppr...
src/pkg/runtime/pprof/pprof_test.go:27: // But do at least 500 iterations (which
should take about 100ms),
On 2014/08/30 17:33:25, rsc wrote:
> The comment says 500 but the code says 100.

Done.

https://codereview.appspot.com/133370043/diff/60001/src/pkg/runtime/pprof/ppr...
src/pkg/runtime/pprof/pprof_test.go:31: for i := 0; i < 100 ||
time.Now().Sub(t0) < 250*time.Millisecond; i++ {
On 2014/08/30 17:01:18, bradfitz wrote:
> time.Since(t0)

Done.

https://codereview.appspot.com/133370043/diff/60001/src/pkg/runtime/pprof/ppr...
src/pkg/runtime/pprof/pprof_test.go:54: 
On 2014/08/30 17:01:18, bradfitz wrote:
> empty line not present in cpuHog2

Done.

[dvyukov, 2014-08-30 18:39:03]

*** Submitted as https://code.google.com/p/go/source/detail?r=46b364806919 ***

runtime/pprof: make CPU profiling tests more robust
Under the race detector most of the samples go into race runtime,
because of that freebsd race builder constantly fails on this test.

LGTM=bradfitz, rsc
R=golang-codereviews, bradfitz, rsc
CC=golang-codereviews, minux
https://codereview.appspot.com/133370043

[gobot, 2014-08-30 20:11:02]

This CL appears to have broken the windows-386 builder.
See http://build.golang.org/log/8ead94a66617e6f8084270e134363bfa0cfd95bd