Issue 13632047: code review 13632047: undo CL 13348045 / 43675523c526

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13632047: code review 13632047: undo CL 13348045 / 43675523c526 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rsc

Modified:
11 years, 8 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

undo CL 13348045 / 43675523c526 There is no reason to do this, and it's more work. ««« original CL description net: make channel-based semaphore depend on receive, not send R=r, dvyukov CC=golang-dev https://codereview.appspot.com/13348045 Committer: Rob Pike <r@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r e176e9d59540 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r 9f2e6632a0c5 https://code.google.com/p/go/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	src/pkg/net/net.go	View	1 2	1 chunk	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 8 months ago (2013-09-11 14:46:04 UTC) #1

LGTM with comment https://codereview.appspot.com/13632047/diff/3001/src/pkg/net/net.go File src/pkg/net/net.go (right): https://codereview.appspot.com/13632047/diff/3001/src/pkg/net/net.go#newcode412 src/pkg/net/net.go:412: threadLimit <- struct{}{} worth a comment ...

11 years, 8 months ago (2013-09-11 22:34:21 UTC) #2

rsc

11 years, 8 months ago (2013-09-12 00:29:27 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=5624b0459502 ***

undo CL 13348045 / 43675523c526

There is no reason to do this, and it's more work.

««« original CL description
net: make channel-based semaphore depend on receive, not send

R=r, dvyukov
CC=golang-dev
https://codereview.appspot.com/13348045

Committer: Rob Pike <r@golang.org>
»»»

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/13632047

Expand All Messages | Collapse All Messages