Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 13348045: code review 13348045: net: make channel-based semaphore depend on receive, no... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by kortschak
Modified:
4 years, 2 months ago
Reviewers:
r, rsc, dvyukov
CC:
r, dvyukov, golang-dev
Visibility:
Public.

Description

net: make channel-based semaphore depend on receive, not send

Patch Set 1 #

Patch Set 2 : diff -r 2e89feb1297b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2e89feb1297b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/pkg/net/net.go View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5
kortschak
Hello r@golang.org (cc: dvyukov@google.com, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
4 years, 2 months ago (2013-08-28 23:29:28 UTC) #1
r
LGTM but wait for dvyukov
4 years, 2 months ago (2013-08-29 00:08:41 UTC) #2
dvyukov
LGTM
4 years, 2 months ago (2013-08-29 06:46:51 UTC) #3
r
*** Submitted as https://code.google.com/p/go/source/detail?r=43675523c526 *** net: make channel-based semaphore depend on receive, not send R=r, ...
4 years, 2 months ago (2013-08-29 07:15:07 UTC) #4
rsc
4 years, 2 months ago (2013-09-06 19:30:58 UTC) #5
Message was sent while issue was closed.
I do not understand why this is necessary. Worse, now there is more init-time
work in package net. I would like to roll back this change.

I will continue the discussion on CL 13038043 where it started.

Russ
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4