code review 13388044: go.tools/cmd/oracle: cosmetic tweaks to Emacs.

go.tools/cmd/oracle: cosmetic tweaks to Emacs.

1. call display-buffer after the postprocessing step to avoid display glitch.
2. suppress the postprocessing progress message---it's too verbose.
   (instead I should just make the postprocessing loop faster)

Also: rename channel-peers to just peers for consistency with other commands and documentation.

[adonovan, 2013-09-03 19:25:36]

Hello dominik.honnef@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[Dominik Honnef, 2013-09-03 19:33:25]

LGTM

https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el
File cmd/oracle/oracle.el (right):

https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el#newcod...
cmd/oracle/oracle.el:128: (message nil))
I truly hate counting ) in lisp diffs; I'll assume they're right :)

https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el#newcod...
cmd/oracle/oracle.el:133: (set-window-point w (point-min))))))
If you want you can use goto-char now, before the display-buffer, if
set-window-point causes some cognitive overhead.

https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el#newcod...
cmd/oracle/oracle.el:172: (defun go-oracle-peers ()
Is this supposed to be part of this CL?

[adonovan, 2013-09-03 19:40:43]

https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el
File cmd/oracle/oracle.el (right):

https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el#newcod...
cmd/oracle/oracle.el:128: (message nil))
On 2013/09/03 19:33:25, Dominik Honnef wrote:
> I truly hate counting ) in lisp diffs; I'll assume they're right :)

You can assume the (manual) Emacs test in this directory passes before I mail
out each review.

https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el#newcod...
cmd/oracle/oracle.el:133: (set-window-point w (point-min))))))
On 2013/09/03 19:33:25, Dominik Honnef wrote:
> If you want you can use goto-char now, before the display-buffer, if
> set-window-point causes some cognitive overhead.

set-window-point is the logically right thing here: I want to move the
scrollbar, not the point.

https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el#newcod...
cmd/oracle/oracle.el:172: (defun go-oracle-peers ()
On 2013/09/03 19:33:25, Dominik Honnef wrote:
> Is this supposed to be part of this CL?

Yes; it makes the command names systematic (go-oracle-xxx) which makes the
documentation simpler.

I've updated the CL description.

[adonovan, 2013-09-03 19:41:07]

*** Submitted as
https://code.google.com/p/go/source/detail?r=eb8b5b6f18de&repo=tools ***

go.tools/cmd/oracle: cosmetic tweaks to Emacs.

1. call display-buffer after the postprocessing step to avoid display glitch.
2. suppress the postprocessing progress message---it's too verbose.
   (instead I should just make the postprocessing loop faster)

Also: rename channel-peers to just peers for consistency with other commands and
documentation.

R=dominik.honnef
CC=golang-dev
https://codereview.appspot.com/13388044