Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 13388044: code review 13388044: go.tools/cmd/oracle: cosmetic tweaks to Emacs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by adonovan
Modified:
8 years, 8 months ago
Reviewers:
Dominik Honnef
CC:
Dominik Honnef, golang-dev
Visibility:
Public.

Description

go.tools/cmd/oracle: cosmetic tweaks to Emacs. 1. call display-buffer after the postprocessing step to avoid display glitch. 2. suppress the postprocessing progress message---it's too verbose. (instead I should just make the postprocessing loop faster) Also: rename channel-peers to just peers for consistency with other commands and documentation.

Patch Set 1 #

Patch Set 2 : diff -r 07183b5c385c https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 07183b5c385c https://code.google.com/p/go.tools #

Total comments: 6

Patch Set 4 : diff -r e3058b01f286 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M cmd/oracle/oracle.el View 1 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 4
adonovan
Hello dominik.honnef@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
8 years, 8 months ago (2013-09-03 19:25:36 UTC) #1
Dominik Honnef
LGTM https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el File cmd/oracle/oracle.el (right): https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el#newcode128 cmd/oracle/oracle.el:128: (message nil)) I truly hate counting ) in ...
8 years, 8 months ago (2013-09-03 19:33:25 UTC) #2
adonovan
https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el File cmd/oracle/oracle.el (right): https://codereview.appspot.com/13388044/diff/5001/cmd/oracle/oracle.el#newcode128 cmd/oracle/oracle.el:128: (message nil)) On 2013/09/03 19:33:25, Dominik Honnef wrote: > ...
8 years, 8 months ago (2013-09-03 19:40:43 UTC) #3
adonovan
8 years, 8 months ago (2013-09-03 19:41:07 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=eb8b5b6f18de&repo=tools ***

go.tools/cmd/oracle: cosmetic tweaks to Emacs.

1. call display-buffer after the postprocessing step to avoid display glitch.
2. suppress the postprocessing progress message---it's too verbose.
   (instead I should just make the postprocessing loop faster)

Also: rename channel-peers to just peers for consistency with other commands and
documentation.

R=dominik.honnef
CC=golang-dev
https://codereview.appspot.com/13388044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b