Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1511)

Issue 133810043: code review 133810043: undo CL 130240043 / b09f70c301a5 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by dfc
Modified:
3 years, 1 month ago
Reviewers:
rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

undo CL 130240043 / b09f70c301a5 This change broke divmod.go on all arm platforms. ««« original CL description cmd/gc: change interface representation: only pointers in data word Note that there are various cleanups that can be made if we keep this change, but I do not want to start making changes that depend on this one until the 1.4 cycle closes. Fixes issue 8405. LGTM=r R=golang-codereviews, adg, r, bradfitz CC=golang-codereviews, iant https://codereview.appspot.com/130240043 »»»

Patch Set 1 #

Patch Set 2 : diff -r a12bd711545558d5d22d154f8ed7fafe647b6303 https://code.google.com/p/go #

Patch Set 3 : diff -r a12bd711545558d5d22d154f8ed7fafe647b6303 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/gc/subr.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
dfc
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
3 years, 1 month ago (2014-08-24 00:06:09 UTC) #1
rsc
LGTM we'll try again later. that's why this was set up to be easy to ...
3 years, 1 month ago (2014-08-24 01:46:36 UTC) #2
rsc
3 years, 1 month ago (2014-08-24 01:52:18 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=e3775b98a663 ***

undo CL 130240043 / b09f70c301a5

This change broke divmod.go on all arm platforms.

««« original CL description
cmd/gc: change interface representation: only pointers in data word

Note that there are various cleanups that can be made if we keep
this change, but I do not want to start making changes that
depend on this one until the 1.4 cycle closes.

Fixes issue 8405.

LGTM=r
R=golang-codereviews, adg, r, bradfitz
CC=golang-codereviews, iant
https://codereview.appspot.com/130240043
»»»

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/133810043

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted