Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1609)

Issue 130240043: code review 130240043: cmd/gc: change interface representation: only pointers ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by rsc
Modified:
3 years, 1 month ago
Reviewers:
r, gobot, dfc
CC:
golang-codereviews, adg, r, bradfitz, iant
Visibility:
Public.

Description

cmd/gc: change interface representation: only pointers in data word Note that there are various cleanups that can be made if we keep this change, but I do not want to start making changes that depend on this one until the 1.4 cycle closes. Fixes issue 8405.

Patch Set 1 #

Patch Set 2 : diff -r d9b3cbdfc09f54349ade880a7549764edebc081f https://code.google.com/p/go/ #

Patch Set 3 : diff -r d9b3cbdfc09f54349ade880a7549764edebc081f https://code.google.com/p/go/ #

Patch Set 4 : diff -r 82e0fbcd5d93f448f84a0ed594632a6dbae473dc https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/gc/subr.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
rsc
Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/
3 years, 1 month ago (2014-08-19 01:25:24 UTC) #1
adg
On 19 August 2014 11:25, <rsc@golang.org> wrote: > until the 1.4 cycle opens. Do you ...
3 years, 1 month ago (2014-08-19 01:32:31 UTC) #2
rsc
R=r Thanks, I meant '1.4 closes'.
3 years, 1 month ago (2014-08-19 01:45:28 UTC) #3
r
LGTM
3 years, 1 month ago (2014-08-19 03:53:28 UTC) #4
bradfitz
Can we get some benchcmp of the go1 benchmarks in the CL description? Or just ...
3 years, 1 month ago (2014-08-19 03:55:51 UTC) #5
r
Some stuff will be faster, some will be slower. But it's staying put anyway; it ...
3 years, 1 month ago (2014-08-19 03:58:00 UTC) #6
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=b09f70c301a5 *** cmd/gc: change interface representation: only pointers in data word Note ...
3 years, 1 month ago (2014-08-23 23:24:46 UTC) #7
gobot
This CL appears to have broken the netbsd-amd64-bsiegert builder. See http://build.golang.org/log/320043d1268cc8c040b9d067a0f453892eda30fd
3 years, 1 month ago (2014-08-23 23:35:12 UTC) #8
dfc
3 years, 1 month ago (2014-08-23 23:49:44 UTC) #9
Message was sent while issue was closed.
On 2014/08/23 23:35:12, gobot wrote:
> This CL appears to have broken the netbsd-amd64-bsiegert builder.
> See http://build.golang.org/log/320043d1268cc8c040b9d067a0f453892eda30fd

It also looks like its broken some arm builders

# ../test
# go run run.go -- divmod.go
incorrect output
runtime: g1: leftover defer argp=0x102207bc pc=0x132c0
	defer 0x10230000 argp=0x102207bc pc=0x132c0
fatal error: traceback has leftover defers or panics

runtime stack:
runtime.throw(0x5b935)
	/usr/local/go/src/pkg/runtime/panic.c:510 +0x60 fp=0x10237ce0 sp=0x10237cd4
runtime.gentraceback(0x36908, 0x10220670, 0x17310, 0x102020a0, 0x0, 0x0,
0x7fffffff, 0x1ddb4, 0x0, 0x1000)
	/usr/local/go/src/pkg/runtime/traceback_arm.c:77 +0xa10 fp=0x10237d68
sp=0x10237ce0
scanstack(0x102020a0)
	/usr/local/go/src/pkg/runtime/mgc0.c:802 +0x128 fp=0x10237da8 sp=0x10237d68
markroot(0x10212000, 0x5)
	/usr/local/go/src/pkg/runtime/mgc0.c:570 +0xf8 fp=0x10237de4 sp=0x10237da8
runtime.parfordo(0x10212000)
	/usr/local/go/src/pkg/runtime/parfor.c:88 +0xc0 fp=0x10237e58 sp=0x10237de4
gc(0x10237fbc)
	/usr/local/go/src/pkg/runtime/mgc0.c:1458 +0x190 fp=0x10237f8c sp=0x10237e58
runtime.gc_m()
	/usr/local/go/src/pkg/runtime/mgc0.c:1417 +0xe4 fp=0x10237fc8 sp=0x10237f8c
runtime.onM(0x0)
	/usr/local/go/src/pkg/runtime/asm_arm.s:212 +0x3c fp=0x10237fcc sp=0x10237fc8
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted