code review 13261055: cmd/go: fix missing __mingw_fprintf symbol for cgo on w...

cmd/go: fix missing __mingw_fprintf symbol for cgo on windows

Fixes issue 5986.

[minux1, 2013-09-19 03:30:02]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2013-09-19 03:55:36]

LGTM

[brainman, 2013-09-19 03:56:55]

LGTM

Thank you.

Alex

[minux1, 2013-09-19 04:58:35]

Hi Russ and Alex,

To complete the fix of known windows cgo problems, I still have a patch
like this:
diff -r e3fb358fb3c6 src/cmd/ld/ldpe.c
--- a/src/cmd/ld/ldpe.c Wed Sep 18 22:27:25 2013 -0400
+++ b/src/cmd/ld/ldpe.c Thu Sep 19 00:55:29 2013 -0400
@@ -468,6 +468,7 @@
  break;
  case IMAGE_SYM_CLASS_NULL:
  case IMAGE_SYM_CLASS_STATIC:
+ case IMAGE_SYM_CLASS_LABEL:
  s = lookup(name, version);
  s->dupok = 1;
  break;

but as of now, i don't come up with a small standalone test for the problem.
is it ok to main a CL with this patch without a proper test?

the reporter of the problem have verified with all three patches applied,
the
problem is fixed.

[brainman, 2013-09-19 05:03:58]

On 2013/09/19 04:58:35, minux wrote:
> 
> ... I still have a patch
> like this:

I take it, the diff is unrelated to this CL? If yes, then, please, send it in a
new CL with proper description.

> @@ -468,6 +468,7 @@
>   break;
>   case IMAGE_SYM_CLASS_NULL:
>   case IMAGE_SYM_CLASS_STATIC:
> + case IMAGE_SYM_CLASS_LABEL:
>   s = lookup(name, version);
>   s->dupok = 1;
>   break;
> 

I am not familiar with that code, but I will look. Thank you.

Alex

[minux1, 2013-09-19 05:19:56]

On Thu, Sep 19, 2013 at 1:03 AM, <alex.brainman@gmail.com> wrote:

> I take it, the diff is unrelated to this CL? If yes, then, please, send
> it in a new CL with proper description.

just sent https://codereview.appspot.com/13722050.

[minux1, 2013-09-19 05:20:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=45d005b47fc0 ***

cmd/go: fix missing __mingw_fprintf symbol for cgo on windows

Fixes issue 5986.

R=golang-dev, rsc, alex.brainman
CC=golang-dev
https://codereview.appspot.com/13261055