Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(197)

Issue 13261055: code review 13261055: cmd/go: fix missing __mingw_fprintf symbol for cgo on w... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by minux1
Modified:
6 years, 1 month ago
Reviewers:
brainman, rsc
CC:
golang-dev, rsc, brainman
Visibility:
Public.

Description

cmd/go: fix missing __mingw_fprintf symbol for cgo on windows Fixes issue 5986.

Patch Set 1 #

Patch Set 2 : diff -r 45343b9c3db4 https://code.google.com/p/go #

Patch Set 3 : diff -r e3fb358fb3c6 https://code.google.com/p/go #

Patch Set 4 : diff -r e3fb358fb3c6 https://code.google.com/p/go #

Patch Set 5 : diff -r e3fb358fb3c6 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M misc/cgo/test/cgo_test.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A misc/cgo/test/issue5986.go View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M src/cmd/go/build.go View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7
minux1
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
6 years, 1 month ago (2013-09-19 03:30:02 UTC) #1
rsc
LGTM
6 years, 1 month ago (2013-09-19 03:55:36 UTC) #2
brainman
LGTM Thank you. Alex
6 years, 1 month ago (2013-09-19 03:56:55 UTC) #3
minux1
Hi Russ and Alex, To complete the fix of known windows cgo problems, I still ...
6 years, 1 month ago (2013-09-19 04:58:35 UTC) #4
brainman
On 2013/09/19 04:58:35, minux wrote: > > ... I still have a patch > like ...
6 years, 1 month ago (2013-09-19 05:03:58 UTC) #5
minux1
On Thu, Sep 19, 2013 at 1:03 AM, <alex.brainman@gmail.com> wrote: > I take it, the ...
6 years, 1 month ago (2013-09-19 05:19:56 UTC) #6
minux1
6 years, 1 month ago (2013-09-19 05:20:10 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=45d005b47fc0 ***

cmd/go: fix missing __mingw_fprintf symbol for cgo on windows

Fixes issue 5986.

R=golang-dev, rsc, alex.brainman
CC=golang-dev
https://codereview.appspot.com/13261055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b