Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(814)

Issue 13722050: code review 13722050: cmd/ld: handle IMAGE_SYM_CLASS_LABEL symbols. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by minux1
Modified:
10 years, 7 months ago
Reviewers:
brainman, adg
CC:
golang-dev, brainman, adg
Visibility:
Public.

Description

cmd/ld: handle IMAGE_SYM_CLASS_LABEL symbols. Was causing "invalid symbol binding" and thus "malformed pe file" error.

Patch Set 1 #

Patch Set 2 : diff -r e3fb358fb3c6 https://code.google.com/p/go #

Patch Set 3 : diff -r e3fb358fb3c6 https://code.google.com/p/go #

Patch Set 4 : diff -r 45d005b47fc0 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/cmd/ld/ldpe.c View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
minux1
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 7 months ago (2013-09-19 05:19:04 UTC) #1
brainman
LGTM for all I know about it. Do you have any reference to the problem ...
10 years, 7 months ago (2013-09-19 05:25:55 UTC) #2
minux1
On Thu, Sep 19, 2013 at 1:25 AM, <alex.brainman@gmail.com> wrote: > Do you have any ...
10 years, 7 months ago (2013-09-19 06:12:33 UTC) #3
brainman
Sounds good. Given that we are not changing things, perhaps we should wait for someone ...
10 years, 7 months ago (2013-09-19 06:22:25 UTC) #4
adg
LGTM
10 years, 7 months ago (2013-09-19 06:26:37 UTC) #5
minux1
10 years, 7 months ago (2013-09-19 06:27:58 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=b8680c5c8a9f ***

cmd/ld: handle IMAGE_SYM_CLASS_LABEL symbols.
Was causing "invalid symbol binding" and thus "malformed pe file" error.

R=golang-dev, alex.brainman, adg
CC=golang-dev
https://codereview.appspot.com/13722050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b