Issue 134740043: Make net.url_open reuse connections again.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 134740043: Make net.url_open reuse connections again. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by vadimsh

Modified:
11 years, 10 months ago

Reviewers:
M-A

CC:
swarming-eng_googlegroups.com, csharp+cc_chromium.org, vadimsh+cc_chromium.org

Base URL:
https://code.google.com/p/swarming.client/@master

Visibility:
Public.

More Reviews

Description

Make net.url_open reuse connections again. The regression was introduced in cfb60855. R=maruel@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=client&r=46266fe

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	utils/net.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

vadimsh

When investigating swarming:147 I've noticed isolateserver.py opens crapload of connections...

11 years, 10 months ago (2014-08-22 22:14:25 UTC) #1

M-A

On 2014/08/22 22:14:25, vadimsh wrote: > When investigating swarming:147 I've noticed isolateserver.py opens crapload of ...

11 years, 10 months ago (2014-08-23 13:42:44 UTC) #2

vadimsh

11 years, 10 months ago (2014-08-25 19:23:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 46266fe (presubmit successful).

Expand All Messages | Collapse All Messages