Issue 12974043: code review 12974043: cmd/go: delete 'go doc'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12974043: code review 12974043: cmd/go: delete 'go doc' (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by r

Modified:
10 years, 8 months ago

Reviewers:
dsymonds, rsc, adg

CC:
golang-dev, dsymonds, adg, rog, rsc

Visibility:
Public.

Description

cmd/go: delete 'go doc' It's next to useless and confusing as well. Let's make godoc better instead. Fixes issue 4849.

Patch Set 1 #

Patch Set 2 : diff -r 706237839622 https://code.google.com/p/go/ #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -70 lines)			Patch
M	src/cmd/go/doc.go	View	4 chunks	+1 line, -24 lines	0 comments	Download
M	src/cmd/go/fmt.go	View	3 chunks	+1 line, -43 lines	0 comments	Download
M	src/cmd/go/main.go	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 11

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

10 years, 8 months ago (2013-08-15 04:57:36 UTC) #1

rog

I for one will miss this,. I use it all the time as a very ...

10 years, 8 months ago (2013-08-15 14:07:32 UTC) #8

rsc

LGTM Deleting this now should open the door to something better in 1.3.

10 years, 8 months ago (2013-08-15 14:37:44 UTC) #9

10 years, 8 months ago (2013-08-16 00:30:13 UTC) #11

*** Submitted as https://code.google.com/p/go/source/detail?r=93fe65926d2c ***

cmd/go: delete 'go doc'
It's next to useless and confusing as well. Let's make godoc better instead.

Fixes issue 4849.

R=golang-dev, dsymonds, adg, rogpeppe, rsc
CC=golang-dev
https://codereview.appspot.com/12974043

Expand All Messages | Collapse All Messages