Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(262)

Issue 12974043: code review 12974043: cmd/go: delete 'go doc' (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by r
Modified:
4 years, 3 months ago
Reviewers:
dsymonds, rsc, adg
CC:
golang-dev, dsymonds, adg, rog, rsc
Visibility:
Public.

Description

cmd/go: delete 'go doc' It's next to useless and confusing as well. Let's make godoc better instead. Fixes issue 4849.

Patch Set 1 #

Patch Set 2 : diff -r 706237839622 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -70 lines) Patch
M src/cmd/go/doc.go View 4 chunks +1 line, -24 lines 0 comments Download
M src/cmd/go/fmt.go View 3 chunks +1 line, -43 lines 0 comments Download
M src/cmd/go/main.go View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
4 years, 3 months ago (2013-08-15 04:57:36 UTC) #1
dsymonds
LGTM
4 years, 3 months ago (2013-08-15 05:13:59 UTC) #2
r
thanks. i'll wait for a few more LGTMs before submitting.
4 years, 3 months ago (2013-08-15 05:57:20 UTC) #3
dsymonds
LGTM
4 years, 3 months ago (2013-08-15 06:32:59 UTC) #4
dsymonds
LGTM
4 years, 3 months ago (2013-08-15 06:33:15 UTC) #5
dsymonds
LGTM
4 years, 3 months ago (2013-08-15 06:33:21 UTC) #6
adg
LGTM
4 years, 3 months ago (2013-08-15 06:45:22 UTC) #7
rog
I for one will miss this,. I use it all the time as a very ...
4 years, 3 months ago (2013-08-15 14:07:32 UTC) #8
rsc
LGTM Deleting this now should open the door to something better in 1.3.
4 years, 3 months ago (2013-08-15 14:37:44 UTC) #9
r
Rog: go doc is the same as godoc . -rob
4 years, 3 months ago (2013-08-15 22:18:37 UTC) #10
r
4 years, 3 months ago (2013-08-16 00:30:13 UTC) #11
*** Submitted as https://code.google.com/p/go/source/detail?r=93fe65926d2c ***

cmd/go: delete 'go doc'
It's next to useless and confusing as well. Let's make godoc better instead.

Fixes issue 4849.

R=golang-dev, dsymonds, adg, rogpeppe, rsc
CC=golang-dev
https://codereview.appspot.com/12974043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4