code review 12822045: cmd/gc: better error messages for C-style if statements.

cmd/gc: better error messages for C-style if statements.
Given
        if (i == 0)
                x++
The old message was
        x.go:6: syntax error: unexpected semicolon or newline before {
Now we see
        x.go:6: syntax error: missing { after if clause

Fixes issue 5687

[r, 2013-08-19 01:34:22]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2013-08-19 01:35:31]

Fixes issue 5687

[adg, 2013-08-19 01:40:16]

LGTM

But I'm getting "Can't parse the patch to chunks" trying to view y.tab.c, which
I'm sure is fine.

[r, 2013-08-19 01:49:27]

i did another upload anyway.

[r, 2013-08-19 01:49:54]

Hello golang-dev@googlegroups.com, adg@golang.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2013-08-19 01:50:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=5f3eab224f84 ***

cmd/gc: better error messages for C-style if statements.
Given
        if (i == 0)
                x++
The old message was
        x.go:6: syntax error: unexpected semicolon or newline before {
Now we see
        x.go:6: syntax error: missing { after if clause

Fixes issue 5687

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/12822045

[adg, 2013-08-19 01:56:24]

Wow, there's a significant change in y.tab.c because you're using bison
2.3, while the previous version was generated with 2.5.

Is this going to be an issue? There's a substantial code delta here
irrelevant to the change.


On 19 August 2013 11:50, <r@golang.org> wrote:

> *** Submitted as
>
https://code.google.com/p/go/**source/detail?r=5f3eab224f84<https://code.goog...
>
>
> cmd/gc: better error messages for C-style if statements.
> Given
>         if (i == 0)
>                 x++
> The old message was
>         x.go:6: syntax error: unexpected semicolon or newline before {
> Now we see
>         x.go:6: syntax error: missing { after if clause
>
> Fixes issue 5687
>
> R=golang-dev, adg
> CC=golang-dev
>
https://codereview.appspot.**com/12822045<https://codereview.appspot.com/1282...
>
>
>
https://codereview.appspot.**com/12822045/<https://codereview.appspot.com/128...
>

[r, 2013-08-19 02:35:55]

It shouldn't, but of course it might. If someone has 2.5 and wants to
regenerate y.tab.c, please feel free. We can let it soak for a while
and see what goes wrong.

Does anyone know what the difference is between the versions? I would
be surprised if the grammar is actually different.

-rob

[adg, 2013-08-19 02:41:27]

I don't know the difference, but I too have 2.3 on my OS X 10.8.4 system.


On 19 August 2013 12:35, Rob Pike <r@golang.org> wrote:

> It shouldn't, but of course it might. If someone has 2.5 and wants to
> regenerate y.tab.c, please feel free. We can let it soak for a while
> and see what goes wrong.
>
> Does anyone know what the difference is between the versions? I would
> be surprised if the grammar is actually different.
>
> -rob
>

[dsymonds, 2013-08-19 02:44:56]

On 19 August 2013 12:35, Rob Pike <r@golang.org> wrote:

> It shouldn't, but of course it might. If someone has 2.5 and wants to
> regenerate y.tab.c, please feel free. We can let it soak for a while
> and see what goes wrong.

https://codereview.appspot.com/12744048

[dave_cheney.net, 2013-08-19 02:47:35]

Nice. 

On 19/08/2013, at 11:50, r@golang.org wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=5f3eab224f84 ***
> 
> cmd/gc: better error messages for C-style if statements.
> Given
>        if (i == 0)
>                x++
> The old message was
>        x.go:6: syntax error: unexpected semicolon or newline before {
> Now we see
>        x.go:6: syntax error: missing { after if clause
> 
> Fixes issue 5687
> 
> R=golang-dev, adg
> CC=golang-dev
> https://codereview.appspot.com/12822045
> 
> 
> https://codereview.appspot.com/12822045/
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.