Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(89)

Issue 12744048: code review 12744048: cmd/gc: regenerate y.tab.{c,h} with Bison 2.5. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by dsymonds
Modified:
12 years, 2 months ago
Reviewers:
r, rsc
CC:
golang-dev, r
Visibility:
Public.

Description

cmd/gc: regenerate y.tab.{c,h} with Bison 2.5.

Patch Set 1 #

Patch Set 2 : diff -r 9fb09f7edb82 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9fb09f7edb82 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9fb09f7edb82 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+959 lines, -355 lines) Patch
M src/cmd/gc/y.tab.h View 1 3 chunks +25 lines, -21 lines 0 comments Download
M src/cmd/gc/y.tab.c View 1 315 chunks +934 lines, -334 lines 0 comments Download

Messages

Total messages: 5
dsymonds
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 2 months ago (2013-08-19 02:45:10 UTC) #1
dsymonds
The only diffs between the version of these files before Rob's change and these are ...
12 years, 2 months ago (2013-08-19 02:48:11 UTC) #2
r
LGTM Let's try this out, because Bison will continue to update. If it breaks, we ...
12 years, 2 months ago (2013-08-19 03:38:17 UTC) #3
dsymonds
*** Submitted as https://code.google.com/p/go/source/detail?r=b68d5c753d91 *** cmd/gc: regenerate y.tab.{c,h} with Bison 2.5. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/12744048
12 years, 2 months ago (2013-08-19 03:47:50 UTC) #4
rsc
12 years, 2 months ago (2013-09-03 20:34:57 UTC) #5
FWIW, it seems like everyone who modifies go.y has a different copy of
bison.
That doesn't bother me: they all seem to work fine, and no one reads the
y.tab.[ch] diffs anyway.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b