code review 128110045: [release-branch.go1.3] net: prevent spurious on-connect...

[release-branch.go1.3] net: prevent spurious on-connect events via epoll on linux

««« CL 120820043 / 06a4b59c1393
net: prevent spurious on-connect events via epoll on linux

On Linux, adding a socket descriptor to epoll instance before getting
the EINPROGRESS return value from connect system call could be a root
cause of spurious on-connect events.

See golang.org/issue/8276, golang.org/issue/8426 for further information.

All credit to Jason Eggleston <jason@eggnet.com>

Fixes issue 8276.
Fixes issue 8426.

LGTM=dvyukov
R=dvyukov, golang-codereviews, adg, dave, iant, alex.brainman
CC=golang-codereviews
https://codereview.appspot.com/120820043
»»»

[adg, 2014-08-13 03:17:58]

Hello r, rsc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adg, 2014-08-13 03:18:11]

*** Submitted as https://code.google.com/p/go/source/detail?r=073fc578434b ***

[release-branch.go1.3] net: prevent spurious on-connect events via epoll on
linux

««« CL 120820043 / 06a4b59c1393
net: prevent spurious on-connect events via epoll on linux

On Linux, adding a socket descriptor to epoll instance before getting
the EINPROGRESS return value from connect system call could be a root
cause of spurious on-connect events.

See golang.org/issue/8276, golang.org/issue/8426 for further information.

All credit to Jason Eggleston <jason@eggnet.com>

Fixes issue 8276.
Fixes issue 8426.

LGTM=dvyukov
R=dvyukov, golang-codereviews, adg, dave, iant, alex.brainman
CC=golang-codereviews
https://codereview.appspot.com/120820043
»»»

TBR=r, rsc
CC=golang-codereviews
https://codereview.appspot.com/128110045

[gobot, 2014-08-13 09:14:39]

This CL appears to have broken the nacl-amd64p32 builder.
See http://build.golang.org/log/2f3099d48f30f0d750516edca3fd31affb785848

[dfc, 2014-08-13 09:32:12]

nope. not true



# GOMAXPROCS=2 runtime -cpu=1,2,4
--- FAIL: TestStackGrowth-2 (20.60 seconds)
stack_test.go:170: finalizer did not run
--- FAIL: TestEmptyString-4 (4.01 seconds)
mfinal_test.go:213: finalizer of next string in memory didn't run
--- FAIL: TestStackGrowth-4 (20.63 seconds)
stack_test.go:170: finalizer did not run
FAIL
FAIL runtime 57.933s

On Wed, Aug 13, 2014 at 7:14 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the nacl-amd64p32 builder.
> See http://build.golang.org/log/2f3099d48f30f0d750516edca3fd31affb785848
>
>
> https://codereview.appspot.com/128110045/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.