Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(388)

Issue 120820043: code review 120820043: net: prevent spurious on-connect events via epoll on linux (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by mikio
Modified:
8 years, 4 months ago
Reviewers:
dvyukov
CC:
dvyukov, golang-codereviews, adg, dfc, iant, brainman
Visibility:
Public.

Description

net: prevent spurious on-connect events via epoll on linux On Linux, adding a socket descriptor to epoll instance before getting the EINPROGRESS return value from connect system call could be a root cause of spurious on-connect events. See golang.org/issue/8276, golang.org/issue/8426 for further information. All credit to Jason Eggleston <jason@eggnet.com> Fixes issue 8276. Fixes issue 8426.

Patch Set 1 : diff -r ba125b11fd2d https://code.google.com/p/go #

Patch Set 2 : diff -r cd8dbfda7b87 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -19 lines) Patch
M src/pkg/net/fd_unix.go View 2 chunks +14 lines, -4 lines 0 comments Download
M src/pkg/net/fd_windows.go View 1 chunk +8 lines, -1 line 0 comments Download
M src/pkg/net/sock_posix.go View 1 chunk +8 lines, -14 lines 0 comments Download

Messages

Total messages: 14
dvyukov
LGTM
8 years, 4 months ago (2014-07-28 07:41:09 UTC) #1
mikio
Hello dvyukov@google.com, golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years, 4 months ago (2014-07-28 17:25:20 UTC) #2
mikio
anyone whom familiar with windows? +adg: this cl is requested to be included in go1.3.1
8 years, 4 months ago (2014-07-28 23:41:35 UTC) #3
dfc
Is it possible to write a test for this? On 29 Jul 2014 09:41, <mikioh.mikioh@gmail.com> ...
8 years, 4 months ago (2014-07-29 00:45:07 UTC) #4
mikio
On Tue, Jul 29, 2014 at 9:45 AM, Dave Cheney <dave@cheney.net> wrote: > Is it ...
8 years, 4 months ago (2014-07-29 01:21:51 UTC) #5
mikio
On Tue, Jul 29, 2014 at 9:45 AM, Dave Cheney <dave@cheney.net> wrote: > Is it ...
8 years, 4 months ago (2014-07-29 01:27:56 UTC) #6
dfc
I have a few windows vm's, I can try On Tue, Jul 29, 2014 at ...
8 years, 4 months ago (2014-07-29 01:30:01 UTC) #7
iant
On Mon, Jul 28, 2014 at 4:41 PM, <mikioh.mikioh@gmail.com> wrote: > > +adg: this cl ...
8 years, 4 months ago (2014-07-29 01:30:41 UTC) #8
mikio
On Tue, Jul 29, 2014 at 10:30 AM, Dave Cheney <dave@cheney.net> wrote: > I have ...
8 years, 4 months ago (2014-07-29 01:39:38 UTC) #9
mikio
On Tue, Jul 29, 2014 at 10:30 AM, Ian Lance Taylor <iant@golang.org> wrote: > For ...
8 years, 4 months ago (2014-07-29 01:42:00 UTC) #10
brainman
On 2014/07/28 23:41:35, mikio wrote: > anyone whom familiar with windows? > This builds on ...
8 years, 4 months ago (2014-07-29 03:37:02 UTC) #11
mikio
On Tue, Jul 29, 2014 at 12:37 PM, <alex.brainman@gmail.com> wrote: > This builds on windows ...
8 years, 4 months ago (2014-07-29 05:30:14 UTC) #12
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=06a4b59c1393 *** net: prevent spurious on-connect events via epoll on linux On ...
8 years, 4 months ago (2014-07-29 07:48:20 UTC) #13
dfc
8 years, 4 months ago (2014-07-29 07:52:14 UTC) #14
It would have been better to wait until the build was not broken before
submitting this change.


On Tue, Jul 29, 2014 at 5:48 PM, <mikioh.mikioh@gmail.com> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=06a4b59c1393 ***
>
>
> net: prevent spurious on-connect events via epoll on linux
>
> On Linux, adding a socket descriptor to epoll instance before getting
> the EINPROGRESS return value from connect system call could be a root
> cause of spurious on-connect events.
>
> See golang.org/issue/8276, golang.org/issue/8426 for further
> information.
>
> All credit to Jason Eggleston <jason@eggnet.com>
>
> Fixes issue 8276.
> Fixes issue 8426.
>
> LGTM=dvyukov
> R=dvyukov, golang-codereviews, adg, dave, iant, alex.brainman
> CC=golang-codereviews
> https://codereview.appspot.com/120820043
>
>
> https://codereview.appspot.com/120820043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b