This CL introduces absPath function that is just a copy of syscall.getFullPath. I was wandering, ...
10 years, 7 months ago
(2014-08-07 05:59:40 UTC)
#2
This CL introduces absPath function that is just a copy of syscall.getFullPath.
I was wandering, if I can put it in one of those "internal" packages or
something. I would need similar function in path/filepath later to fix issue
8145. Seems like a waste to repeat it 3 times. Suggestions are welcome.
Alex
Rob is working on moving syscall to go.sys. Once that's done we can export the ...
10 years, 7 months ago
(2014-08-11 20:32:08 UTC)
#4
Rob is working on moving syscall to go.sys.
Once that's done we can export the code as FullPath, in both places.
But we need to finish the copy first.
Thanks.
On 2014/08/13 21:17:12, bradfitz wrote: > Can this go shared AbsPath function go in the ...
10 years, 7 months ago
(2014-08-14 04:21:10 UTC)
#7
On 2014/08/13 21:17:12, bradfitz wrote:
> Can this go shared AbsPath function go in the new
> $GOROOT/src/pkg/internal/syscall package that I created yesterday?
Sure. Done.
I wonder, if syscall is a good name for the new package. It might clash with old
syscall at times. Perhaps we could keep internal/syscall for "all OSes code",
but put windows specific code into "internal/syscall/windows" similar to go.sys?
Same for plan9 and unix. What do you think?
Alex
SGTM. Actually don't care either way. The internal system lets us change it whenever. On ...
10 years, 7 months ago
(2014-08-14 04:53:04 UTC)
#8
SGTM. Actually don't care either way. The internal system lets us change it
whenever.
On Aug 13, 2014 9:21 PM, <alex.brainman@gmail.com> wrote:
> On 2014/08/13 21:17:12, bradfitz wrote:
>
>> Can this go shared AbsPath function go in the new
>> $GOROOT/src/pkg/internal/syscall package that I created yesterday?
>>
>
> Sure. Done.
>
> I wonder, if syscall is a good name for the new package. It might clash
> with old syscall at times. Perhaps we could keep internal/syscall for
> "all OSes code", but put windows specific code into
> "internal/syscall/windows" similar to go.sys? Same for plan9 and unix.
> What do you think?
>
> Alex
>
> https://codereview.appspot.com/127740043/
>
On 2014/08/14 05:00:36, r wrote: > I'm not fussed either way ... Lets leave it ...
10 years, 7 months ago
(2014-08-14 05:11:40 UTC)
#10
On 2014/08/14 05:00:36, r wrote:
> I'm not fussed either way ...
Lets leave it as is for now in internal/syscall
> ... but I thought the thinking was that the
> function was useful anyway, so why not put it in syscall and go.sys
> both?
Do you mean syscall or internal/syscall? I though syscall is closed for *any*
changes (especially for additions). I don't really care if it gets coplied into
go.sys or not. I need this function in syscall, os and path/filepath. But I
could put it into go.sys, if we want ...
Alex
Here's what Russ wrote, and I think it's fine: "Rob is working on moving syscall ...
10 years, 7 months ago
(2014-08-14 13:57:53 UTC)
#11
Here's what Russ wrote, and I think it's fine:
"Rob is working on moving syscall to go.sys.
Once that's done we can export the code as FullPath, in both places.
But we need to finish the copy first.
"
The syscall package is closed to development for things like new
syscalls, but to support the standard library I'm fine with a simple
change like this that seems useful. As time goes on, "internal" will
grow and the likelihood of such changes will go down, but this thing
seems fine to me. It looks like a useful function.
-rob
On Wed, Aug 13, 2014 at 10:11 PM, <alex.brainman@gmail.com> wrote:
> On 2014/08/14 05:00:36, r wrote:
>>
>> I'm not fussed either way ...
>
>
> Lets leave it as is for now in internal/syscall
>
>> ... but I thought the thinking was that the
>>
>> function was useful anyway, so why not put it in syscall and go.sys
>> both?
>
>
> Do you mean syscall or internal/syscall? I though syscall is closed for
> *any* changes (especially for additions). I don't really care if it gets
> coplied into go.sys or not. I need this function in syscall, os and
> path/filepath. But I could put it into go.sys, if we want ...
>
> Alex
>
> https://codereview.appspot.com/127740043/
Unrelated but ... Should syscall related changes from https://codereview.appspot.com/122200043/ go into syscall? Or should we ...
10 years, 7 months ago
(2014-08-15 01:18:04 UTC)
#15
Unrelated but ...
Should syscall related changes from https://codereview.appspot.com/122200043/ go
into syscall? Or should we move them into internal/syscall or
internal/syscall/windows? Thank you.
Alex
some syscall stuff has landed for 1.4. this change is so small i'm ok with ...
10 years, 7 months ago
(2014-08-15 02:15:04 UTC)
#16
some syscall stuff has landed for 1.4. this change is so small i'm ok
with it, but make sure it gets into go.sys/windows as well.
after 1.4 the hammer comes down. it's halfway down already.
On Thu, Aug 14, 2014 at 6:18 PM, <alex.brainman@gmail.com> wrote:
> Unrelated but ...
>
> Should syscall related changes from
> https://codereview.appspot.com/122200043/ go into syscall? Or should we
> move them into internal/syscall or internal/syscall/windows? Thank you.
>
> Alex
>
> https://codereview.appspot.com/127740043/
Issue 127740043: code review 127740043: os: make SameFile handle paths like c:a.txt properly
(Closed)
Created 10 years, 7 months ago by brainman
Modified 10 years, 7 months ago
Reviewers:
Base URL:
Comments: 0