Issue 130250043: code review 130250043: go.sys/windows: apply latest syscall changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 130250043: code review 130250043: go.sys/windows: apply latest syscall changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by brainman

Modified:
9 years, 8 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

go.sys/windows: apply latest syscall changes 71db3dc120af os: make SameFile handle paths like c:a.txt properly ff34a3e84dc0 net: fix CNAME resolving on Windows

Patch Set 1 #

Patch Set 2 : diff -r fd938b2de18a86e6c4700e61318a296c1916e977 https://code.google.com/p/go.sys #

Patch Set 3 : diff -r fd938b2de18a86e6c4700e61318a296c1916e977 https://code.google.com/p/go.sys #

Patch Set 4 : diff -r fd938b2de18a86e6c4700e61318a296c1916e977 https://code.google.com/p/go.sys #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -8 lines)			Patch
M	windows/exec_windows.go	View	1	4 chunks	+7 lines, -8 lines	0 comments	Download
M	windows/syscall_windows.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	windows/zsyscall_windows.go	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	windows/ztypes_windows.go	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.sys

9 years, 8 months ago (2014-08-19 05:56:11 UTC) #1

brainman

9 years, 8 months ago (2014-08-20 02:25:24 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=305dbc5a350e&repo=sys ***

go.sys/windows: apply latest syscall changes

71db3dc120af os: make SameFile handle paths like c:a.txt properly
ff34a3e84dc0 net: fix CNAME resolving on Windows

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/130250043

Expand All Messages | Collapse All Messages