Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(269)

Issue 12751045: code review 12751045: encoding/xml: support generic encoding interfaces (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by rsc
Modified:
4 years, 3 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

encoding/xml: support generic encoding interfaces Remove custom support for time.Time. No new tests: the tests for the time.Time special case now test the general case.

Patch Set 1 #

Patch Set 2 : diff -r 7b9e2c29bf14 https://code.google.com/p/go/ #

Total comments: 4

Patch Set 3 : diff -r 0a4959c5402a https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -50 lines) Patch
M src/pkg/encoding/xml/marshal.go View 1 12 chunks +86 lines, -30 lines 0 comments Download
M src/pkg/encoding/xml/read.go View 1 2 11 chunks +71 lines, -19 lines 0 comments Download
M src/pkg/encoding/xml/xml.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/go/build/deps_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
4 years, 3 months ago (2013-08-14 19:36:53 UTC) #1
bradfitz
LGTM https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.go File src/pkg/encoding/xml/read.go (right): https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.go#newcode204 src/pkg/encoding/xml/read.go:204: // which is known to implement TextUnmarshaler. The ...
4 years, 3 months ago (2013-08-14 20:45:14 UTC) #2
rsc
https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.go File src/pkg/encoding/xml/read.go (right): https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.go#newcode206 src/pkg/encoding/xml/read.go:206: func (p *Decoder) unmarshalTextInterface(val encoding.TextUnmarshaler, start *StartElement) error { ...
4 years, 3 months ago (2013-08-14 21:04:58 UTC) #3
bradfitz
https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.go File src/pkg/encoding/xml/read.go (right): https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.go#newcode206 src/pkg/encoding/xml/read.go:206: func (p *Decoder) unmarshalTextInterface(val encoding.TextUnmarshaler, start *StartElement) error { ...
4 years, 3 months ago (2013-08-14 21:49:50 UTC) #4
rsc
no worries. my first attempt did pass foobarbaz. there's a test for that.
4 years, 3 months ago (2013-08-14 22:51:45 UTC) #5
rsc
4 years, 3 months ago (2013-08-14 22:52:16 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=1b67c839e83d ***

encoding/xml: support generic encoding interfaces

Remove custom support for time.Time.
No new tests: the tests for the time.Time special case
now test the general case.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12751045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4