code review 12751045: encoding/xml: support generic encoding interfaces

encoding/xml: support generic encoding interfaces

Remove custom support for time.Time.
No new tests: the tests for the time.Time special case
now test the general case.

[rsc, 2013-08-14 19:36:53]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-14 20:45:14]

LGTM

https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.go
File src/pkg/encoding/xml/read.go (right):

https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.g...
src/pkg/encoding/xml/read.go:204: // which is known to implement
TextUnmarshaler. The chardata
"which is known to implement TextUnmarshaler" seems redundant, consider that is
its type.

https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.g...
src/pkg/encoding/xml/read.go:206: func (p *Decoder) unmarshalTextInterface(val
encoding.TextUnmarshaler, start *StartElement) error {
so <root>foo<x>bar</x>baz</root> passes "foobarbaz" to val.UnmarshalText?  Seems
weird.  Fine, I guess, though.

[rsc, 2013-08-14 21:04:58]

https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.go
File src/pkg/encoding/xml/read.go (right):

https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.g...
src/pkg/encoding/xml/read.go:206: func (p *Decoder) unmarshalTextInterface(val
encoding.TextUnmarshaler, start *StartElement) error {
On 2013/08/14 20:45:14, bradfitz wrote:
> so <root>foo<x>bar</x>baz</root> passes "foobarbaz" to val.UnmarshalText? 
Seems
> weird.  Fine, I guess, though.

No, it passes foobaz. Still weird but consistent with ,chardata fields.

[bradfitz, 2013-08-14 21:49:50]

https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.go
File src/pkg/encoding/xml/read.go (right):

https://codereview.appspot.com/12751045/diff/2002/src/pkg/encoding/xml/read.g...
src/pkg/encoding/xml/read.go:206: func (p *Decoder) unmarshalTextInterface(val
encoding.TextUnmarshaler, start *StartElement) error {
On 2013/08/14 21:04:58, rsc wrote:
> On 2013/08/14 20:45:14, bradfitz wrote:
> > so <root>foo<x>bar</x>baz</root> passes "foobarbaz" to val.UnmarshalText? 
> Seems
> > weird.  Fine, I guess, though.
> 
> No, it passes foobaz. Still weird but consistent with ,chardata fields.

I'm blind.

[rsc, 2013-08-14 22:51:45]

no worries. my first attempt did pass foobarbaz. there's a test for that.

[rsc, 2013-08-14 22:52:16]

*** Submitted as https://code.google.com/p/go/source/detail?r=1b67c839e83d ***

encoding/xml: support generic encoding interfaces

Remove custom support for time.Time.
No new tests: the tests for the time.Time special case
now test the general case.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12751045