code review 127490043: runtime: convert Gosched to Go

runtime: convert Gosched to Go

[dvyukov, 2014-08-18 18:03:36]

Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org,
rsc@golang.org),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[rlh, 2014-08-18 20:04:05]

On 2014/08/18 18:03:36, dvyukov wrote:
> Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:khr@golang.org,
mailto:rlh@golang.org,
> mailto:rsc@golang.org),
> 
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/

Is gosched the best name for this routine? Perhaps yield, yieldgoproc, or
yieldgoprocessor?
The actual code looks fine.

[bradfitz, 2014-08-18 20:08:19]

On Mon, Aug 18, 2014 at 1:04 PM, <rlh@golang.org> wrote:

> On 2014/08/18 18:03:36, dvyukov wrote:
>
>> Hello mailto:golang-codereviews@googlegroups.com (cc:
>>
> mailto:khr@golang.org, mailto:rlh@golang.org,
>
>> mailto:rsc@golang.org),
>>
>
>  I'd like you to review this change to
>> https://dvyukov%40google.com@code.google.com/p/go/
>>
>
> Is gosched the best name for this routine? Perhaps yield, yieldgoproc,
> or yieldgoprocessor?
>

Given that the Go1 API compatibility promise (
https://golang.org/doc/go1compat) prohibits us from changing the public
face of this (http://golang.org/pkg/runtime/#Gosched), it probably makes
sense to make the internal code use the same name as the public name.

[rlh, 2014-08-18 20:22:12]

On 2014/08/18 20:08:19, bradfitz wrote:
> On Mon, Aug 18, 2014 at 1:04 PM, <mailto:rlh@golang.org> wrote:
> 
> > On 2014/08/18 18:03:36, dvyukov wrote:
> >
> >> Hello mailto:golang-codereviews@googlegroups.com (cc:
> >>
> > mailto:khr@golang.org, mailto:rlh@golang.org,
> >
> >> mailto:rsc@golang.org),
> >>
> >
> >  I'd like you to review this change to
> >> https://dvyukov%40google.com@code.google.com/p/go/
> >>
> >
> > Is gosched the best name for this routine? Perhaps yield, yieldgoproc,
> > or yieldgoprocessor?
> >
> 
> Given that the Go1 API compatibility promise (
> https://golang.org/doc/go1compat) prohibits us from changing the public
> face of this (http://golang.org/pkg/runtime/#Gosched), it probably makes
> sense to make the internal code use the same name as the public name.

LGTM

[khr, 2014-08-18 20:24:36]

On 2014/08/18 20:22:12, rlh wrote:
> On 2014/08/18 20:08:19, bradfitz wrote:
> > On Mon, Aug 18, 2014 at 1:04 PM, <mailto:rlh@golang.org> wrote:
> > 
> > > On 2014/08/18 18:03:36, dvyukov wrote:
> > >
> > >> Hello mailto:golang-codereviews@googlegroups.com (cc:
> > >>
> > > mailto:khr@golang.org, mailto:rlh@golang.org,
> > >
> > >> mailto:rsc@golang.org),
> > >>
> > >
> > >  I'd like you to review this change to
> > >> https://dvyukov%40google.com@code.google.com/p/go/
> > >>
> > >
> > > Is gosched the best name for this routine? Perhaps yield, yieldgoproc,
> > > or yieldgoprocessor?
> > >
> > 
> > Given that the Go1 API compatibility promise (
> > https://golang.org/doc/go1compat) prohibits us from changing the public
> > face of this (http://golang.org/pkg/runtime/#Gosched), it probably makes
> > sense to make the internal code use the same name as the public name.
> 
> LGTM

LGTM.

[dvyukov, 2014-08-19 07:50:05]

*** Submitted as https://code.google.com/p/go/source/detail?r=40ba12acfb6a ***

runtime: convert Gosched to Go

LGTM=rlh, khr
R=golang-codereviews, rlh, bradfitz, khr
CC=golang-codereviews, rsc
https://codereview.appspot.com/127490043

[gobot, 2014-08-19 11:15:24]

This CL appears to have broken the linux-and64-perf builder.
See http://build.golang.org/log/1c7702617b15e1c0929a58485118742dbabb9c74