Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 127490043: code review 127490043: runtime: convert Gosched to Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dvyukov
Modified:
10 years, 7 months ago
Reviewers:
gobot, khr, rlh
CC:
golang-codereviews, rlh, bradfitz, khr, rsc
Visibility:
Public.

Description

runtime: convert Gosched to Go

Patch Set 1 #

Patch Set 2 : diff -r b86ee06ef235d5766845f44056f152e1808da110 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r b86ee06ef235d5766845f44056f152e1808da110 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r e34ca40b4857b9ba020e0cacf182044599cb0a1a https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M src/pkg/runtime/extern.go View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 2 chunks +4 lines, -10 lines 0 comments Download
A src/pkg/runtime/proc.go View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/stack.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/stubs.go View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 7 months ago (2014-08-18 18:03:36 UTC) #1
rlh
On 2014/08/18 18:03:36, dvyukov wrote: > Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:khr@golang.org, mailto:rlh@golang.org, > mailto:rsc@golang.org), > > ...
10 years, 7 months ago (2014-08-18 20:04:05 UTC) #2
bradfitz
On Mon, Aug 18, 2014 at 1:04 PM, <rlh@golang.org> wrote: > On 2014/08/18 18:03:36, dvyukov ...
10 years, 7 months ago (2014-08-18 20:08:19 UTC) #3
rlh
On 2014/08/18 20:08:19, bradfitz wrote: > On Mon, Aug 18, 2014 at 1:04 PM, <mailto:rlh@golang.org> ...
10 years, 7 months ago (2014-08-18 20:22:12 UTC) #4
khr
On 2014/08/18 20:22:12, rlh wrote: > On 2014/08/18 20:08:19, bradfitz wrote: > > On Mon, ...
10 years, 7 months ago (2014-08-18 20:24:36 UTC) #5
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=40ba12acfb6a *** runtime: convert Gosched to Go LGTM=rlh, khr R=golang-codereviews, rlh, bradfitz, ...
10 years, 7 months ago (2014-08-19 07:50:05 UTC) #6
gobot
10 years, 7 months ago (2014-08-19 11:15:24 UTC) #7
Message was sent while issue was closed.
This CL appears to have broken the linux-and64-perf builder.
See http://build.golang.org/log/1c7702617b15e1c0929a58485118742dbabb9c74
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b