Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 7 months ago
(2014-08-18 18:03:36 UTC)
#1
10 years, 7 months ago
(2014-08-18 20:04:05 UTC)
#2
On 2014/08/18 18:03:36, dvyukov wrote:
> Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:khr@golang.org,
mailto:rlh@golang.org,
> mailto:rsc@golang.org),
>
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/
Is gosched the best name for this routine? Perhaps yield, yieldgoproc, or
yieldgoprocessor?
The actual code looks fine.
On Mon, Aug 18, 2014 at 1:04 PM, <rlh@golang.org> wrote: > On 2014/08/18 18:03:36, dvyukov ...
10 years, 7 months ago
(2014-08-18 20:08:19 UTC)
#3
On Mon, Aug 18, 2014 at 1:04 PM, <rlh@golang.org> wrote:
> On 2014/08/18 18:03:36, dvyukov wrote:
>
>> Hello mailto:golang-codereviews@googlegroups.com (cc:
>>
> mailto:khr@golang.org, mailto:rlh@golang.org,
>
>> mailto:rsc@golang.org),
>>
>
> I'd like you to review this change to
>> https://dvyukov%40google.com@code.google.com/p/go/
>>
>
> Is gosched the best name for this routine? Perhaps yield, yieldgoproc,
> or yieldgoprocessor?
>
Given that the Go1 API compatibility promise (
https://golang.org/doc/go1compat) prohibits us from changing the public
face of this (http://golang.org/pkg/runtime/#Gosched), it probably makes
sense to make the internal code use the same name as the public name.
On 2014/08/18 20:08:19, bradfitz wrote: > On Mon, Aug 18, 2014 at 1:04 PM, <mailto:rlh@golang.org> ...
10 years, 7 months ago
(2014-08-18 20:22:12 UTC)
#4
On 2014/08/18 20:08:19, bradfitz wrote:
> On Mon, Aug 18, 2014 at 1:04 PM, <mailto:rlh@golang.org> wrote:
>
> > On 2014/08/18 18:03:36, dvyukov wrote:
> >
> >> Hello mailto:golang-codereviews@googlegroups.com (cc:
> >>
> > mailto:khr@golang.org, mailto:rlh@golang.org,
> >
> >> mailto:rsc@golang.org),
> >>
> >
> > I'd like you to review this change to
> >> https://dvyukov%40google.com@code.google.com/p/go/
> >>
> >
> > Is gosched the best name for this routine? Perhaps yield, yieldgoproc,
> > or yieldgoprocessor?
> >
>
> Given that the Go1 API compatibility promise (
> https://golang.org/doc/go1compat) prohibits us from changing the public
> face of this (http://golang.org/pkg/runtime/#Gosched), it probably makes
> sense to make the internal code use the same name as the public name.
LGTM
On 2014/08/18 20:22:12, rlh wrote: > On 2014/08/18 20:08:19, bradfitz wrote: > > On Mon, ...
10 years, 7 months ago
(2014-08-18 20:24:36 UTC)
#5
On 2014/08/18 20:22:12, rlh wrote:
> On 2014/08/18 20:08:19, bradfitz wrote:
> > On Mon, Aug 18, 2014 at 1:04 PM, <mailto:rlh@golang.org> wrote:
> >
> > > On 2014/08/18 18:03:36, dvyukov wrote:
> > >
> > >> Hello mailto:golang-codereviews@googlegroups.com (cc:
> > >>
> > > mailto:khr@golang.org, mailto:rlh@golang.org,
> > >
> > >> mailto:rsc@golang.org),
> > >>
> > >
> > > I'd like you to review this change to
> > >> https://dvyukov%40google.com@code.google.com/p/go/
> > >>
> > >
> > > Is gosched the best name for this routine? Perhaps yield, yieldgoproc,
> > > or yieldgoprocessor?
> > >
> >
> > Given that the Go1 API compatibility promise (
> > https://golang.org/doc/go1compat) prohibits us from changing the public
> > face of this (http://golang.org/pkg/runtime/#Gosched), it probably makes
> > sense to make the internal code use the same name as the public name.
>
> LGTM
LGTM.
Issue 127490043: code review 127490043: runtime: convert Gosched to Go
(Closed)
Created 10 years, 7 months ago by dvyukov
Modified 10 years, 7 months ago
Reviewers: gobot
Base URL:
Comments: 0